[coreboot-gerrit] Patch set updated for coreboot: pcengines/apu1: Add ACPI led, button and GPIO devices.

Tobias Diedrich (ranma+coreboot@tdiedrich.de) gerrit at coreboot.org
Sun Jun 14 14:59:37 CEST 2015


Tobias Diedrich (ranma+coreboot at tdiedrich.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10540

-gerrit

commit 75e02ede4a26b994b612e6652903db2c9250f025
Author: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
Date:   Sat Jun 13 13:29:50 2015 +0200

    pcengines/apu1: Add ACPI led, button and GPIO devices.
    
    Provide ACPI devices with devicetree-compatible annotations for the three leds
    and the button of the APU1, as well as the GPIO driver.
    
    This will cause the Linux kernel to automatically load the following modules:
      leds_gpio (CONFIG_LEDS_GPIO, devicetree alias gpio-leds)
      gpio_keys_polled (CONFIG_KEYBOARD_GPIO_POLLED, devicetree alias gpio-keys-polled)
      gpio_sb8xx (CONFIG_GPIO_SB8XX, devicetree alias gpio-sb8xx, not sent upstream yet)
    
    See http://events.linuxfoundation.org/sites/events/files/slides/ACPI_vs_DT.pdf
    and https://lwn.net/Articles/612062/ for some more information on how the
    PRP0001 HID works.
    
    To make this usable a Linux GPIO driver for the AMD chipset is also required,
    which I am currently working on, but have not submitted upstream yet.
    
    Change-Id: I956ee92d9d98ef27a83ccb30d314543bd8634f2c
    Signed-off-by: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
---
 src/mainboard/pcengines/apu1/acpi/buttons.asl | 36 +++++++++++++++++
 src/mainboard/pcengines/apu1/acpi/gpio.asl    | 19 +++++++++
 src/mainboard/pcengines/apu1/acpi/leds.asl    | 58 +++++++++++++++++++++++++++
 src/mainboard/pcengines/apu1/dsdt.asl         |  3 ++
 4 files changed, 116 insertions(+)

diff --git a/src/mainboard/pcengines/apu1/acpi/buttons.asl b/src/mainboard/pcengines/apu1/acpi/buttons.asl
new file mode 100644
index 0000000..7daea6a
--- /dev/null
+++ b/src/mainboard/pcengines/apu1/acpi/buttons.asl
@@ -0,0 +1,36 @@
+Scope (\_SB.PCI0.SBUS)
+{
+	Device (BTNS)
+	{
+		Name (_HID, "PRP0001")
+
+		Name (_CRS, ResourceTemplate () {
+			GpioIo (Exclusive, PullUp, 0, 0, IoRestrictionInputOnly,
+				"\\_SB.PCI0.SBUS.GPIO", 0, ResourceConsumer) {187}
+		})
+
+		Name (_DSD, Package () {
+			ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+			Package () {
+				Package () {"compatible", Package () {"gpio-keys-polled"}},
+				Package () {"poll-interval", 100},
+				Package () {"autorepeat", 1}
+			}
+		})
+
+		Device (BTN1)
+		{
+			Name (_DSD, Package () {
+				ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+				Package () {
+					/* BTN_1 is 0x101 in linux/input.h */
+					Package () {"linux,code", 257},
+					Package () {"linux,input-type", 1},
+					/* labeled S1 on the board, MODESW in the gpio header files */
+					Package () {"label", "switch1"},
+					Package () {"gpios", Package () {^^BTNS, 0, 0, 1 /* low-active */}},
+				}
+			})
+		}
+	}
+}
diff --git a/src/mainboard/pcengines/apu1/acpi/gpio.asl b/src/mainboard/pcengines/apu1/acpi/gpio.asl
new file mode 100644
index 0000000..a1c0a74
--- /dev/null
+++ b/src/mainboard/pcengines/apu1/acpi/gpio.asl
@@ -0,0 +1,19 @@
+Scope (\_SB.PCI0.SBUS)
+{
+	Device (GPIO)
+	{
+		Name (_HID, "PRP0001")
+
+		Name (_CRS, ResourceTemplate () {
+			/* ACPI_MMIO_BASE + gpio offset */
+			Memory32Fixed(ReadWrite, 0xFED80100, 0x0000100)
+		})
+
+		Name (_DSD, Package () {
+			ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+			Package () {
+				Package () {"compatible", Package () {"gpio-sb8xx"}},
+			}
+		})
+	}
+}
diff --git a/src/mainboard/pcengines/apu1/acpi/leds.asl b/src/mainboard/pcengines/apu1/acpi/leds.asl
new file mode 100644
index 0000000..62afc3e
--- /dev/null
+++ b/src/mainboard/pcengines/apu1/acpi/leds.asl
@@ -0,0 +1,58 @@
+Scope (\_SB.PCI0.SBUS)
+{
+	Device (LEDS)
+	{
+		Name (_HID, "PRP0001")
+
+		Name (_CRS, ResourceTemplate () {
+			GpioIo (Exclusive, PullUp, 0, 0, IoRestrictionOutputOnly,
+				"\\_SB.PCI0.SBUS.GPIO", 0, ResourceConsumer) {189, 190, 191}
+		})
+
+		Name (_DSD, Package () {
+			ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+			Package () {
+				Package () {"compatible", Package () {"gpio-leds"}},
+			}
+		})
+
+		Device (LED1)
+		{
+			Name (_DSD, Package () {
+				ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+				Package () {
+					Package () {"label", "led1"},
+					Package () {"gpios", Package () {^^LEDS, 0, 0, 1 /* low-active */}},
+					Package () {"linux,default-trigger", "heartbeat"},
+					Package () {"linux,default-state", "keep"},
+				}
+			})
+		}
+
+		Device (LED2)
+		{
+			Name (_DSD, Package () {
+				ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+				Package () {
+					Package () {"label", "led2"},
+					Package () {"gpios", Package () {^^LEDS, 0, 1, 1 /* low-active */}},
+					Package () {"linux,default-trigger", "phy0radio"},
+					Package () {"linux,default-state", "keep"},
+				}
+			})
+		}
+
+		Device (LED3)
+		{
+			Name (_DSD, Package () {
+				ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+				Package () {
+					Package () {"label", "led3"},
+					Package () {"gpios", Package () {^^LEDS, 0, 2, 1 /* low-active */}},
+					Package () {"linux,default-trigger", "phy1radio"},
+					Package () {"linux,default-state", "keep"},
+				}
+			})
+		}
+	}
+}
diff --git a/src/mainboard/pcengines/apu1/dsdt.asl b/src/mainboard/pcengines/apu1/dsdt.asl
index 9358203..53cffa9 100644
--- a/src/mainboard/pcengines/apu1/dsdt.asl
+++ b/src/mainboard/pcengines/apu1/dsdt.asl
@@ -64,6 +64,9 @@ DefinitionBlock (
 	#include "acpi/sleep.asl"
 
 	#include "acpi/gpe.asl"
+	#include "acpi/gpio.asl"
+	#include "acpi/leds.asl"
+	#include "acpi/buttons.asl"
 	#include <southbridge/amd/cimx/sb800/acpi/smbus.asl>
 	#include "acpi/thermal.asl"
 }



More information about the coreboot-gerrit mailing list