[coreboot-gerrit] Patch set updated for coreboot: mainboard/lenovo/t400: Fix HDA verbs to match hardware layout

Michał Masłowski (mtjm@mtjm.eu) gerrit at coreboot.org
Sat Jun 13 23:19:04 CEST 2015

Michał Masłowski (mtjm at mtjm.eu) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10431


commit 6871a7729be6f65ee471e834bc481ba58c5e345f
Author: Michał Masłowski <mtjm at mtjm.eu>
Date:   Fri Jun 5 15:40:48 2015 +0200

    mainboard/lenovo/t400: Fix HDA verbs to match hardware layout
    The same values are used on my Lenovo R400 as reported by Francis Rowe
    from his T400 and T500.
    TEST: Read /proc/asound/card0/codec#0, see that the jack locations
    correspond to the board layout, e.g. headphone and microphone
    connectors are on front of the laptop, not right.  Read
    /sys/class/sound/hwC0D0/init_pin_configs, see that it has the same
    content as with factory firmware.
    Change-Id: I60e914ca9fab4bb2c99b4ed9e6d81a0580a88b18
    Signed-off-by: Michał Masłowski <mtjm at mtjm.eu>
 src/mainboard/lenovo/t400/hda_verb.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/mainboard/lenovo/t400/hda_verb.c b/src/mainboard/lenovo/t400/hda_verb.c
index beb637f..423d10c 100644
--- a/src/mainboard/lenovo/t400/hda_verb.c
+++ b/src/mainboard/lenovo/t400/hda_verb.c
@@ -23,15 +23,15 @@
 const u32 cim_verb_data[] = {
 	/* coreboot specific header */
 	0x14f15051,	// Conexant CX20561 (Hermosa)
-	0x17aa20ff,	// Subsystem ID
+	0x17aa211c,	// Subsystem ID
 	0x00000008,	// Number of entries
 	/* Pin Widget Verb Table */
-	AZALIA_PIN_CFG(0, 0x16, 0x042140f0),
+	AZALIA_PIN_CFG(0, 0x16, 0x022140f0),
 	AZALIA_PIN_CFG(0, 0x17, 0x61a190f0),
-	AZALIA_PIN_CFG(0, 0x18, 0x04a190f0),
-	AZALIA_PIN_CFG(0, 0x19, 0x612140f0),
+	AZALIA_PIN_CFG(0, 0x18, 0x02a190f0),
+	AZALIA_PIN_CFG(0, 0x19, 0x40f000f0),
 	AZALIA_PIN_CFG(0, 0x1a, 0x901701f0),
 	AZALIA_PIN_CFG(0, 0x1b, 0x40f001f0),
 	AZALIA_PIN_CFG(0, 0x1c, 0x40f001f0),

More information about the coreboot-gerrit mailing list