[coreboot-gerrit] Patch set updated for coreboot: ec/lenovo/h8: add commenting to the power_management_beeps code

Francis Rowe (info@gluglug.org.uk) gerrit at coreboot.org
Sat Jun 13 13:49:50 CEST 2015


Francis Rowe (info at gluglug.org.uk) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10532

-gerrit

commit a6f690d7ff6871cdf692012fe699fc1750fe5983
Author: Francis Rowe <info at gluglug.org.uk>
Date:   Sat Jun 13 00:40:53 2015 +0100

    ec/lenovo/h8: add commenting to the power_management_beeps code
    
    Change-Id: I6a9714cacefccac83822113ff184ed58c14233b4
    Signed-off-by: Francis Rowe <info at gluglug.org.uk>
---
 src/ec/lenovo/h8/h8.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c
index df8c424..1f8b091 100644
--- a/src/ec/lenovo/h8/h8.c
+++ b/src/ec/lenovo/h8/h8.c
@@ -214,6 +214,9 @@ static void h8_enable(struct device *dev)
 	beepmask1 = conf->beepmask1;
 
 	if (conf->has_power_management_beeps) {
+		/* Controls whether a "beep" occurs, when connecting
+		 * or disconnecting a power supply for charging the battery
+		 */
 		if (get_option(&val, "power_management_beeps") != CB_SUCCESS)
 			val = 0;
 		if (!val) {
@@ -221,6 +224,10 @@ static void h8_enable(struct device *dev)
 			beepmask1 = 0x00;
 		}
 
+		/*
+		 * Controls whether a "beep" occurs, when the
+		 * battery reaches critically low levels
+		 */
 		if (get_option(&val, "low_battery_beep") != CB_SUCCESS)
 			val = 0;
 		if (val)



More information about the coreboot-gerrit mailing list