[coreboot-gerrit] Patch set updated for coreboot: amd hudson: Base HUDSON_FWM_POSITION on actual ROMSIZE

Tobias Diedrich (ranma+coreboot@tdiedrich.de) gerrit at coreboot.org
Sat Jun 13 12:58:32 CEST 2015

Tobias Diedrich (ranma+coreboot at tdiedrich.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7479


commit e083347277b0ed2c02cdd91819cf9f377ce18ccf
Author: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
Date:   Sun Nov 16 13:50:30 2014 +0100

    amd hudson: Base HUDSON_FWM_POSITION on actual ROMSIZE
    Hudson Kconfig is using BOARD_ROMSIZE to generate HUDSON_FWM_POSITION, make
    it use COREBOOT_ROMSIZE instead, so it'll work when selecting a non-default
    Change-Id: I531418d6a8457b37df87fea131cfa59f2802d7ac
    Signed-off-by: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
 src/southbridge/amd/agesa/hudson/Kconfig | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/src/southbridge/amd/agesa/hudson/Kconfig b/src/southbridge/amd/agesa/hudson/Kconfig
index 610e1fd..411051a 100644
--- a/src/southbridge/amd/agesa/hudson/Kconfig
+++ b/src/southbridge/amd/agesa/hudson/Kconfig
@@ -99,11 +99,15 @@ if HUDSON_FWM
 	hex "Hudson Firmware ROM Position"
-	default 0xFFF20000 if BOARD_ROMSIZE_KB_1024
-	default 0xFFE20000 if BOARD_ROMSIZE_KB_2048
-	default 0xFFC20000 if BOARD_ROMSIZE_KB_4096
-	default 0xFF820000 if BOARD_ROMSIZE_KB_8192
-	default 0xFF020000 if BOARD_ROMSIZE_KB_16384
+	# TODO: Doing the 4GiB - ROMSIZE + 128kiB calculation in Kconfig is
+	# ugly. CBFS will fail the day we need to put aligned 64kiB and 32kiB
+	# files right next to each other? Also if one of these new blobs begins
+	# to write/erase SPI pages, our CBFS headers are at risk.
+	default 0xFFF20000 if COREBOOT_ROMSIZE_KB_1024
+	default 0xFFE20000 if COREBOOT_ROMSIZE_KB_2048
+	default 0xFFC20000 if COREBOOT_ROMSIZE_KB_4096
+	default 0xFF820000 if COREBOOT_ROMSIZE_KB_8192
+	default 0xFF020000 if COREBOOT_ROMSIZE_KB_16384
 	  Hudson requires the firmware MUST be located at
 	  a specific address (ROM start address + 0x20000), otherwise

More information about the coreboot-gerrit mailing list