[coreboot-gerrit] New patch to review for coreboot: b9e7799 google/panther: fix MAC address programming when VPD not present

Matt DeVillier (matt.devillier@gmail.com) gerrit at coreboot.org
Thu Jun 11 05:38:38 CEST 2015

Matt DeVillier (matt.devillier at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10509


commit b9e7799b167279db358124d30cd821580cfc6624
Author: Matt DeVillier <matt.devillier at gmail.com>
Date:   Wed Jun 10 22:31:28 2015 -0500

    google/panther: fix MAC address programming when VPD not present
    commit 899d13d (cbfs: new API and better program loading) broke
    panther's lan init when no vpd.bin present from which to read
    MAC address. Fix this by checking the validity of the search
    address pointer, rather than the search length
    Change-Id: I8c7ca410d8ce5c5d92242a21c4c2ff4c001a68bd
    Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
 src/mainboard/google/panther/lan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mainboard/google/panther/lan.c b/src/mainboard/google/panther/lan.c
index 4b34c06..5d806db 100644
--- a/src/mainboard/google/panther/lan.c
+++ b/src/mainboard/google/panther/lan.c
@@ -132,7 +132,7 @@ static void program_mac_address(u16 io_base)
-	if (search_length <= 0)
+	if (search_address == NULL)
 		printk(BIOS_ERR, "LAN: VPD not found.\n");
 		get_mac_address(&high_dword, &low_dword, search_address,

More information about the coreboot-gerrit mailing list