[coreboot-gerrit] Patch merged into coreboot/master: 5793b73 x86: remove printk() from init_timer()

gerrit at coreboot.org gerrit at coreboot.org
Tue Jun 9 22:25:42 CEST 2015


the following patch was just integrated into master:
commit 5793b7371dd82ad688164122850d63cdbda56859
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Tue Jun 9 15:02:50 2015 -0500

    x86: remove printk() from init_timer()
    
    For console drivers which use udelay() we can deadlock
    in the printk path on the spinlock. The reason is that
    on the first call to udelay() from within a console driver
    it will go back down the printk() path deadlocking oneself.
    
    Just remove the printk() as it was asymmetric on romstage
    vs ramstage.
    
    Change-Id: I30fe7d6e5b4684f17d4f353c0816b64f9242de0a
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: http://review.coreboot.org/10483
    Reviewed-by: Patrick Georgi <pgeorgi at google.com>
    Tested-by: build bot (Jenkins)


See http://review.coreboot.org/10483 for details.

-gerrit



More information about the coreboot-gerrit mailing list