[coreboot-gerrit] Patch set updated for coreboot: 41ed5e9 update submodule when 'make' rather than 'make menuconfig'

WANG Siyuan (wangsiyuanbuaa@gmail.com) gerrit at coreboot.org
Tue Jun 9 07:34:23 CEST 2015

WANG Siyuan (wangsiyuanbuaa at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10472


commit 41ed5e9ddf62e84726e0c01f0a2614b2d828d472
Author: WANG Siyuan <wangsiyuanbuaa at gmail.com>
Date:   Tue Jun 9 11:29:24 2015 +0800

    update submodule when 'make' rather than 'make menuconfig'
    'git submodule update --init' runs before 'make menuconfig'.
    This is very inconvenience when developing.
    CONFIG_USE_BLOBS is used to control updating submodule,
    but the original command is wrong.
    With this patch, people can choose 'Allow use of binary-only repository'
    if they want to update submodule.
    Change-Id: I442da4be18e9d43d7188a1434cc67b4e61456b58
    Signed-off-by: WANG Siyuan <wangsiyuanbuaa at gmail.com>
    Signed-off-by: WANG Siyuan <SiYuan.Wang at amd.com>
 Makefile.inc | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/Makefile.inc b/Makefile.inc
index 585fd17..c8a9f67 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -128,12 +128,9 @@ ifeq ($(CONFIG_COVERAGE),y)
 ramstage-c-ccopts += -fprofile-arcs -ftest-coverage
+ifeq ($(CONFIG_USE_BLOBS),y)
 # try to fetch non-optional submodules if the source is under git
 forgetthis:=$(if $(GIT),$(shell git submodule update --init))
-ifeq ($(CONFIG_USE_BLOBS),y)
-# this is necessary because 3rdparty/blobs is update=none, and so is ignored
-# unless explicitly requested and enabled through --checkout
-forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/blobs))

More information about the coreboot-gerrit mailing list