[coreboot-gerrit] Patch set updated for coreboot: e349f1f pistachio: initialize cbmem area to be empty

Ionela Voinescu (ionela.voinescu@imgtec.com) gerrit at coreboot.org
Mon Jun 8 00:53:37 CEST 2015


Ionela Voinescu (ionela.voinescu at imgtec.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10458

-gerrit

commit e349f1fc3cf6bf0869d3c1b947d2a4b59c409119
Author: Ionela Voinescu <ionela.voinescu at imgtec.com>
Date:   Tue May 26 13:51:31 2015 +0100

    pistachio: initialize cbmem area to be empty
    
    Use cbmem_initialize_empty() after DDR configuration so that
    cbmem is always initialized from scratch on each boot.
    
    Change-Id: Ic9ca34867b26aab82cf3154280694b6fb61ee11f
    Signed-off-by: Ionela Voinescu <ionela.voinescu at imgtec.com>
---
 src/soc/imgtec/pistachio/romstage.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/soc/imgtec/pistachio/romstage.c b/src/soc/imgtec/pistachio/romstage.c
index afa42a7..5509107 100644
--- a/src/soc/imgtec/pistachio/romstage.c
+++ b/src/soc/imgtec/pistachio/romstage.c
@@ -18,6 +18,7 @@
  * Foundation, Inc.
  */
 
+#include <cbmem.h>
 #include <program_loading.h>
 #include <console/console.h>
 #include <halt.h>
@@ -30,6 +31,12 @@ void main(void)
 	error = init_ddr2();
 
 	if (!error) {
+		/*
+		 * When romstage is running it's always on the reboot path
+		 * never a resume path where cbmem recovery is required.
+		 * Therefore, always initialize the cbmem area to be empty.
+		 */
+		cbmem_initialize_empty();
 		run_ramstage();
 	}
 	halt();



More information about the coreboot-gerrit mailing list