[coreboot-gerrit] Patch set updated for coreboot: 3abf888 device/device.c: Improve output in `init_dev()`

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Sun Jun 7 22:08:29 CEST 2015


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10455

-gerrit

commit 3abf8885cedb39789246e68005a121ca0f67d3f9
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Sun Jun 7 20:28:17 2015 +0200

    device/device.c: Improve output in `init_dev()`
    
    Since commit 05294292 (device tree: track init times) there are two
    lines printed for each init() call of a device, when
    `HAVE_MONOTONIC_TIMER` is selected.
    
    	[…]
    	CPU_CLUSTER: 0 init 12708 usecs
    	DOMAIN: 0000 init
    	DOMAIN: 0000 init 1 usecs
    	PCI: 00:00.0 init
    	Northbridge init
    	PCI: 00:00.0 init 2 usecs
    	PCI: 00:01.0 init
    	PCI: 00:01.0 init 1 usecs
    	PCI: 00:01.1 init
    	PCI: 00:01.1 init 1 usecs
    	PCI: 00:11.0 init
    	PCI: 00:11.0 init 1 usecs
    	PCI: 00:14.0 init
    	PCI: 00:14.0 init 1 usecs
    	PCI: 00:14.3 init
    	SB800 - Late.c - lpc_init - Start.
    	RTC Init
    	RTC: coreboot checksum invalid
    	SB800 - Late.c - lpc_init - End.
    	[…]
    
    Improve the output by changing the wording to.
    
    	%s init ...\n
    	init()
    	%s init finished in %ld usecs\n
    
    Note, that `%s init ... done in %ld usecs` is not possible as the
    function `init()` can also print messages.
    
    Change-Id: I7132cd650911dba680f060d6073a5a09c879b24c
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/device/device.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/device/device.c b/src/device/device.c
index 6bdeae1..a768ff7 100644
--- a/src/device/device.c
+++ b/src/device/device.c
@@ -1144,11 +1144,11 @@ static void init_dev(struct device *dev)
 			       dev_path(dev->bus->dev), dev->bus->link_num);
 		}
 
-		printk(BIOS_DEBUG, "%s init\n", dev_path(dev));
+		printk(BIOS_DEBUG, "%s init ...\n", dev_path(dev));
 		dev->initialized = 1;
 		dev->ops->init(dev);
 #if CONFIG_HAVE_MONOTONIC_TIMER
-		printk(BIOS_DEBUG, "%s init %ld usecs\n", dev_path(dev),
+		printk(BIOS_DEBUG, "%s init finished in %ld usecs\n", dev_path(dev),
 			stopwatch_duration_usecs(&sw));
 #endif
 	}



More information about the coreboot-gerrit mailing list