[coreboot-gerrit] New patch to review for coreboot: 7c2f6f9 macbook21: switch off led before jumping to payload

Mono Moosbart (mono@posteo.de) gerrit at coreboot.org
Sun Jun 7 13:33:08 CEST 2015


Mono Moosbart (mono at posteo.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10454

-gerrit

commit 7c2f6f91d08dc181fb7c2fd22b6b4c35d46f9a35
Author: Mono <mono at posteo.de>
Date:   Sun Jun 7 13:21:59 2015 +0200

    macbook21: switch off led before jumping to payload
    
    Mimic vendor BIOS in switching off the led once coreboot has booted successfully
    
    Change-Id: I0dec10b842b83dfc8054cd56d2750b724c4e8576
    Signed-off-by: Mono <mono-for-coreboot at donderklumpen.de>
---
 src/mainboard/apple/macbook21/Kconfig     | 1 +
 src/mainboard/apple/macbook21/mainboard.c | 7 +++++++
 2 files changed, 8 insertions(+)

diff --git a/src/mainboard/apple/macbook21/Kconfig b/src/mainboard/apple/macbook21/Kconfig
index 138ec87..7ad3f93 100644
--- a/src/mainboard/apple/macbook21/Kconfig
+++ b/src/mainboard/apple/macbook21/Kconfig
@@ -8,6 +8,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select NORTHBRIDGE_INTEL_I945
 	select NORTHBRIDGE_INTEL_SUBTYPE_I945GM
 	select SOUTHBRIDGE_INTEL_I82801GX
+	select EC_ACPI
 	select HAVE_OPTION_TABLE
 	select HAVE_CMOS_DEFAULT
 	select HAVE_MP_TABLE
diff --git a/src/mainboard/apple/macbook21/mainboard.c b/src/mainboard/apple/macbook21/mainboard.c
index 8414d11..ef914ec 100644
--- a/src/mainboard/apple/macbook21/mainboard.c
+++ b/src/mainboard/apple/macbook21/mainboard.c
@@ -33,6 +33,7 @@
 #include <arch/x86/include/arch/acpigen.h>
 #include <smbios.h>
 #include <drivers/intel/gma/int15.h>
+#include <ec/acpi/ec.h>
 #define PANEL INT15_5F35_CL_DISPLAY_DEFAULT
 
 static acpi_cstate_t cst_entries[] = {
@@ -84,7 +85,13 @@ static void mainboard_enable(device_t dev)
 	dev->ops->init = mainboard_init;
 }
 
+static void mainboard_final(void *chip_info)
+{
+	ec_set_bit(0x10, 2); /* switch off led */
+}
+
 struct chip_operations mainboard_ops = {
 	.enable_dev = mainboard_enable,
+	.final = mainboard_final,
 };
 



More information about the coreboot-gerrit mailing list