[coreboot-gerrit] New patch to review for coreboot: google/stout: Fix ELOG related ifdefs
Patrick Georgi (pgeorgi@google.com)
gerrit at coreboot.org
Fri Jul 31 17:40:20 CEST 2015
Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11098
-gerrit
commit 8fe04adfac04b17ee6bc680f37f3c11b10fc3e96
Author: Patrick Georgi <pgeorgi at google.com>
Date: Fri Jul 31 17:18:16 2015 +0200
google/stout: Fix ELOG related ifdefs
The used functions require the ELOG_GSMI feature, not just ELOG.
Change-Id: If38cf0b710d9236012bfb1f0b119c10f9e533a25
Signed-off-by: Patrick Georgi <pgeorgi at google.com>
---
src/mainboard/google/stout/ec.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/mainboard/google/stout/ec.c b/src/mainboard/google/stout/ec.c
index 0c3b942..e652a41 100644
--- a/src/mainboard/google/stout/ec.c
+++ b/src/mainboard/google/stout/ec.c
@@ -81,7 +81,7 @@ void stout_ec_finalize_smm(void)
if (ec_reg & 0x8) {
printk(BIOS_ERR, " EC Fan Error\n");
critical_shutdown = 1;
-#if CONFIG_ELOG
+#if CONFIG_ELOG_GSMI
elog_add_event_word(EC_EVENT_BATTERY_CRITICAL, EC_EVENT_FAN_ERROR);
#endif
}
@@ -91,7 +91,7 @@ void stout_ec_finalize_smm(void)
if (ec_reg & 0x80) {
printk(BIOS_ERR, " EC Thermal Device Error\n");
critical_shutdown = 1;
-#if CONFIG_ELOG
+#if CONFIG_ELOG_GSMI
elog_add_event_word(EC_EVENT_BATTERY_CRITICAL, EC_EVENT_THERMAL);
#endif
}
@@ -103,14 +103,14 @@ void stout_ec_finalize_smm(void)
if ((ec_reg & 0xCF) == 0xC0) {
printk(BIOS_ERR, " EC Critical Battery Error\n");
critical_shutdown = 1;
-#if CONFIG_ELOG
+#if CONFIG_ELOG_GSMI
elog_add_event_word(ELOG_TYPE_EC_EVENT, EC_EVENT_BATTERY_CRITICAL);
#endif
}
if ((ec_reg & 0x8F) == 0x8F) {
printk(BIOS_ERR, " EC Read Battery Error\n");
-#if CONFIG_ELOG
+#if CONFIG_ELOG_GSMI
elog_add_event_word(ELOG_TYPE_EC_EVENT, EC_EVENT_BATTERY);
#endif
}
More information about the coreboot-gerrit
mailing list