[coreboot-gerrit] Patch set updated for coreboot: skylake: remove the redundant fspNotify in chip final.

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Wed Jul 29 11:00:21 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11054

-gerrit

commit 5529cb4db663092bffd878c4acc95f61556ed96a
Author: robbie zhang <robbie.zhang at intel.com>
Date:   Thu Jul 23 17:31:56 2015 -0700

    skylake: remove the redundant fspNotify in chip final.
    
    The fspNotify(EnumInitPhaseAfterPciEnumeration) is already
    registered in fsp_util.c as a generic callback, this is some code
    left from early development.
    
    Also I don't see a need for the chip_final function, although we
    could keep it as a placeholder but i decided to remove it.
    
    BUG=chrome-os-partner:42979
    BRANCH=None
    TEST=build with current fsp and the coming fsp 1.3.0, boot on sklrvp3.
    
    Change-Id: Ia892f2021be324859c344b4cb8cdeaf75f7ee32f
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: ae22ad57ddbab787da000ae99f85fd2b3d4092e7
    Original-Change-Id: I41be566da71f80451ff70ddd8ada77bf9b8d5b1d
    Original-Signed-off-by: robbie zhang <robbie.zhang at intel.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/287991
    Original-Reviewed-by: Duncan Laurie <dlaurie at chromium.org>
---
 src/soc/intel/skylake/chip.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/src/soc/intel/skylake/chip.c b/src/soc/intel/skylake/chip.c
index f1a104c..b1b66fc 100644
--- a/src/soc/intel/skylake/chip.c
+++ b/src/soc/intel/skylake/chip.c
@@ -38,17 +38,8 @@ static struct device_operations pci_domain_ops = {
 	.ops_pci_bus      = &pci_bus_default_ops,
 };
 
-static void chip_final(device_t dev)
-{
-	/* Notify FSP done device setup */
-	printk(BIOS_DEBUG,
-		"Calling FspNotify(EnumInitPhaseAfterPciEnumeration)\n");
-	fsp_notify(EnumInitPhaseAfterPciEnumeration);
-}
-
 static struct device_operations cpu_bus_ops = {
 	.init             = &soc_init_cpus,
-	.final            = &chip_final,
 };
 
 static void soc_enable(device_t dev)



More information about the coreboot-gerrit mailing list