[coreboot-gerrit] New patch to review for coreboot: t210: lp0_resume: set CAR2PMC_CPU_ACK_WIDTH to 0

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Wed Jul 22 21:11:41 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11037

-gerrit

commit 8a22bea2b2c24197fb9c05e0feb9a12a2e52c322
Author: Yen Lin <yelin at nvidia.com>
Date:   Thu Jul 16 10:23:34 2015 -0700

    t210: lp0_resume: set CAR2PMC_CPU_ACK_WIDTH to 0
    
    Like in cold boot path, need to set CAR2PMC_CPU_ACK_WIDTH to 0
    in lp0 resume path.
    
    BUG=chrome-os-partner:40741
    BRANCH=None
    TEST=Tested on Smaug; able to suspend/resume
    
    Change-Id: Iffd7fa4d0266e2ec482ec17e5203ceff8afe748f
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 052b649b1e6a4e34d621d710ee43aec7149ab8a8
    Original-Change-Id: Icdf9879469485fb37b820b30c9663eda528ac013
    Original-Signed-off-by: Yen Lin <yelin at nvidia.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/286600
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Original-Commit-Queue: Tom Warren <twarren at nvidia.com>
---
 src/soc/nvidia/tegra210/lp0/tegra_lp0_resume.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/src/soc/nvidia/tegra210/lp0/tegra_lp0_resume.c b/src/soc/nvidia/tegra210/lp0/tegra_lp0_resume.c
index 168c95a..dc61cba 100644
--- a/src/soc/nvidia/tegra210/lp0/tegra_lp0_resume.c
+++ b/src/soc/nvidia/tegra210/lp0/tegra_lp0_resume.c
@@ -146,6 +146,13 @@ enum {
 	CLK_ENB_CSITE = 0x1 << 9
 };
 
+static uint32_t *clk_rst_cpu_softrst_ctrl2_ptr =
+	(void *)(CLK_RST_BASE + 0x388);
+enum {
+	CAR2PMC_CPU_ACK_WIDTH_SHIFT = 0,
+	CAR2PMC_CPU_ACK_WIDTH_MASK = 0xfff << CAR2PMC_CPU_ACK_WIDTH_SHIFT
+};
+
 static uint32_t *clk_rst_clk_enb_v_set_ptr = (void *)(CLK_RST_BASE + 0x440);
 enum {
 	CLK_ENB_CPUG = 0x1 << 0,
@@ -787,6 +794,9 @@ void lp0_resume(void)
 	/* Disable PLLX since it isn't used in the kernel as CPU clk source. */
 	clrbits32(PLLX_ENABLE, clk_rst_pllx_base_ptr);
 
+	/* Set CAR2PMC_CPU_ACK_WIDTH to 0 */
+	clrbits32(CAR2PMC_CPU_ACK_WIDTH_MASK, clk_rst_cpu_softrst_ctrl2_ptr);
+
 	/* Clear PMC_SCRATCH190 */
 	clrbits32(1, pmc_scratch190_ptr);
 



More information about the coreboot-gerrit mailing list