[coreboot-gerrit] Patch merged into coreboot/master: mec: Correct the access mode for short payloads

gerrit at coreboot.org gerrit at coreboot.org
Tue Jul 21 21:22:19 CEST 2015


the following patch was just integrated into master:
commit f4e9eb9aba875768cbd80241e3770659bdafd643
Author: Jagadish Krishnamoorthy <jagadish.krishnamoorthy at intel.com>
Date:   Sat Jul 18 11:46:37 2015 -0700

    mec: Correct the access mode for short payloads
    
    If the Host Command payload is less than 4 bytes
    and is word aligned then the payload was not transferred at all.
    EC reads the old packet and CRC mismatch occurs.
    
    In this issue, the HC command packet
    consisting of EC_CMD_REBOOT_EC as command and EC_REBOOT_COLD
    as payload encountered the same problem as above.
    Hence select byte access mode for shorter payloads.
    
    BRANCH=None
    BUG=chrome-os-partner:42396
    TEST=System should boot after
    chromeos-firmwareupdate
    
    Change-Id: I22bdb739108d31b592c20247be69c198d617d359
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 8a43d2636b1bbfbac0384e1ea5e8853a7bd87a7f
    Original-Change-Id: I5572093436f4f4a0fc337efa943753ab4642d8e4
    Original-Signed-off-by: Jagadish Krishnamoorthy <jagadish.krishnamoorthy at intel.com>
    Original-Signed-off-by: Icarus Sparry <icarus.w.sparry at intel.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/286537
    Original-Reviewed-by: Shawn N <shawnn at chromium.org>
    Reviewed-on: http://review.coreboot.org/11012
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/11012 for details.

-gerrit



More information about the coreboot-gerrit mailing list