[coreboot-gerrit] Patch set updated for coreboot: intel/common: remove printk in pre_console_init()

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Tue Jul 21 20:14:34 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10996

-gerrit

commit 8af9115871047ea46e1644106db4a44b2a91dd0d
Author: rsatapat <rishavnath.satapathy at intel.com>
Date:   Mon Jul 6 21:03:02 2015 +0530

    intel/common: remove printk in pre_console_init()
    
    printk called before console init causes sluggish execution because
    of Rx timeout.
    
    BRANCH=None
    BUG=chrome-os-partner:40857
    TEST=Built for sklrvp and tested LPSS logs on RVP3 and Kunimitsu.
    
    Change-Id: I61d5c0f5a4e93695bcba90b7ac7d4f68e2d625be
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 77c58702c8279c6d9c6ae1c946bf1b76df20714d
    Original-Change-Id: Ib85029456059248cc2c88aaccba4fa12cc5a76be
    Original-Signed-off-by: rsatapat <rishavnath.satapathy at intel.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/284823
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Original-Commit-Queue: Wenkai Du <wenkai.du at intel.com>
    Original-Tested-by: Wenkai Du <wenkai.du at intel.com>
---
 src/soc/intel/common/romstage.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/soc/intel/common/romstage.c b/src/soc/intel/common/romstage.c
index 919de83..370d973 100644
--- a/src/soc/intel/common/romstage.c
+++ b/src/soc/intel/common/romstage.c
@@ -231,7 +231,6 @@ __attribute__((weak)) void mainboard_check_ec_image(
 __attribute__((weak)) void mainboard_pre_console_init(
 	struct romstage_params *params)
 {
-	printk(BIOS_DEBUG, "WEAK: %s/%s called\n", __FILE__, __func__);
 }
 
 /* Board initialization before and after RAM is enabled */



More information about the coreboot-gerrit mailing list