[coreboot-gerrit] New patch to review for coreboot: Cyan: Fix for Crossystem "wpsw_cur" status

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Mon Jul 20 22:29:38 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11010

-gerrit

commit b032deaa5f11522472953340090dd850e4cd589b
Author: Hannah Williams <hannah.williams at intel.com>
Date:   Fri Jul 17 17:04:25 2015 -0700

    Cyan: Fix for Crossystem "wpsw_cur" status
    
    The GPIO mapping was incorrect for wpsw_cur. The GPIOs for East community were
    in two ranges - 0: INT33FF:02 GPIOS [373 - 384] PINS [0 - 11]  and
    12: INT33FF:02 GPIOS [385 - 396] PINS [15 - 26]
    The discontinuity was not accounted for, hence the error.Original offset was
     0x16 whereas it should be 0x13
    
    BUG=chrome-os-partner:42798
    BRANCH=None
    TEST=Run crossystem and test wpsw_cur entry. If screw is present, it should
    be 1 and if not present, it should be 0
    
    Change-Id: I2faea1fe1415c9d4cb23444d03c7c9d47c87e8e5
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 30ac96f606a5618e9ef12bac3f50fac433141acd
    Original-Change-Id: I166a7c3e15a990b507ae3c13e15ab56bee7fb917
    Original-Signed-off-by: Hannah Williams <hannah.williams at intel.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/286534
    Original-Reviewed-by: Shawn N <shawnn at chromium.org>
---
 src/mainboard/google/cyan/acpi/chromeos.asl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mainboard/google/cyan/acpi/chromeos.asl b/src/mainboard/google/cyan/acpi/chromeos.asl
index 4ba3857..4e5cd54 100644
--- a/src/mainboard/google/cyan/acpi/chromeos.asl
+++ b/src/mainboard/google/cyan/acpi/chromeos.asl
@@ -33,5 +33,5 @@
 Name(OIPG, Package() {
 	/* No physical recovery button */
 	Package () { 0x0001, 0, 0xFFFFFFFF, "Braswell" },
-	Package () { 0x0003, 1, 0x10016, "Braswell" },
+	Package () { 0x0003, 1, 0x10013, "Braswell" },
 })



More information about the coreboot-gerrit mailing list