[coreboot-gerrit] New patch to review for coreboot: intel raminit: whitespace fixes and improved logging

[Patrick Rudolph (siro@das-labor.org)]

Patrick Rudolph (siro at das-labor.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10888

-gerrit

commit 0c082fe80e440cd552e1097f4614a03958499892
Author: Patrick Rudolph <siro at das-labor.org>
Date:   Sun Jul 12 11:39:45 2015 +0200

    intel raminit: whitespace fixes and improved logging
    
    Remove whitespace errors and print the unmodified timB value, too.
    
    Change-Id: If69244a5d47424e3e984fdf782ea9d2d3c466d86
    Signed-off-by: Patrick Rudolph <siro at das-labor.org>
---
 src/northbridge/intel/sandybridge/raminit_native.c | 25 +++++++++++-----------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/src/northbridge/intel/sandybridge/raminit_native.c b/src/northbridge/intel/sandybridge/raminit_native.c
index 3740a02..0c98b7a 100644
--- a/src/northbridge/intel/sandybridge/raminit_native.c
+++ b/src/northbridge/intel/sandybridge/raminit_native.c
@@ -2300,7 +2300,7 @@ static int get_timB_high_adjust(u64 val)
 
 static void adjust_high_timB(ramctr_timing * ctrl)
 {
-	int channel, slotrank, lane;
+	int channel, slotrank, lane, old;
 	write32(DEFAULT_MCHBAR + 0x3400, 0x200);
 	FOR_ALL_POPULATED_CHANNELS {
 		fill_pattern1(ctrl, channel);
@@ -2370,17 +2370,18 @@ static void adjust_high_timB(ramctr_timing * ctrl)
 		wait_428c(channel);
 		FOR_ALL_LANES {
 			u64 res =
-			    read32(DEFAULT_MCHBAR + lane_registers[lane] +
-				   0x100 * channel + 4);
-			 res |=
-			    ((u64) read32(DEFAULT_MCHBAR + lane_registers[lane] +
-					  0x100 * channel + 8)) << 32;
-			 ctrl->timings[channel][slotrank].lanes[lane].timB +=
-			    get_timB_high_adjust(res) * 64;
-
-			 printk(BIOS_DEBUG, "High adjust %d:%016llx\n", lane, res);
-			 printram("Bval+: %d, %d, %d, %x\n", channel,
-				slotrank, lane,
+				read32(DEFAULT_MCHBAR + lane_registers[lane] +
+					0x100 * channel + 4);
+			res |=
+				((u64) read32(DEFAULT_MCHBAR + lane_registers[lane] +
+					0x100 * channel + 8)) << 32;
+			old = ctrl->timings[channel][slotrank].lanes[lane].timB;
+			ctrl->timings[channel][slotrank].lanes[lane].timB +=
+				get_timB_high_adjust(res) * 64;
+
+			printk(BIOS_DEBUG, "High adjust %d:%016llx\n", lane, res);
+			printram("Bval+: %d, %d, %d, %x -> %x\n", channel,
+				slotrank, lane, old,
 				ctrl->timings[channel][slotrank].lanes[lane].
 				timB);
 		}