[coreboot-gerrit] Patch merged into coreboot/master: Calculate HUDSON_FWM_POSITION and display warning on mismatch
gerrit at coreboot.org
gerrit at coreboot.org
Sat Jul 11 22:13:31 CEST 2015
the following patch was just integrated into master:
commit d12d65fc54c31ee2635c0249a1d92c2e70bc1498
Author: Martin Roth <gaumless at gmail.com>
Date: Sun Jun 28 14:06:23 2015 -0600
Calculate HUDSON_FWM_POSITION and display warning on mismatch
This patch calculates the address where the chipset firmware descriptor
should be located and compares it against the actual value from Kconfig.
If the two don't match, it puts up a warning.
This could probably replace the config variable completely, but I wanted
to see how other people felt before doing that. I seem to recall that
the value used to be calculated, so I figure that there must be a reason
it's done this way at this point.
If we do want to keep the Kconfig setting, this patch could also be
modified to just verify that the HUDSON_FWM_POSITION is inside the ROM
space.
Change-Id: I94addf463e2c694a94eef218ec855103a3bb5da5
Signed-off-by: Martin Roth <gaumless at gmail.com>
Reviewed-on: http://review.coreboot.org/10682
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
See http://review.coreboot.org/10682 for details.
-gerrit
More information about the coreboot-gerrit
mailing list