[coreboot-gerrit] New patch to review for coreboot: x86emu/debug.h: remove #ifdef CONFIG_DEFAULT_CONSOLE_LOGLEVEL

Martin Roth (gaumless@gmail.com) gerrit at coreboot.org
Sat Jul 11 22:01:46 CEST 2015


Martin Roth (gaumless at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10887

-gerrit

commit c53b27327be88ddaa8e496b78e39afaec9d8f287
Author: Martin Roth <gaumless at gmail.com>
Date:   Sat Jul 11 14:01:12 2015 -0600

    x86emu/debug.h: remove #ifdef CONFIG_DEFAULT_CONSOLE_LOGLEVEL
    
    This protection didn't make sense to me - it seems like things would
    probably break if printf wasn't defined anyway.
    
    Change-Id: Ifb6bad46e193b35c13b7ad4946511fec74beff92
    Signed-off-by: Martin Roth <gaumless at gmail.com>
---
 src/device/oprom/x86emu/debug.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/device/oprom/x86emu/debug.h b/src/device/oprom/x86emu/debug.h
index 6858f15..186c161 100644
--- a/src/device/oprom/x86emu/debug.h
+++ b/src/device/oprom/x86emu/debug.h
@@ -42,10 +42,8 @@
 
 /*---------------------- Macros and type definitions ----------------------*/
 
-#ifdef CONFIG_DEFAULT_CONSOLE_LOGLEVEL
 /* printf is not available in coreboot... use printk */
 #define printf(x...) printk(BIOS_DEBUG, x)
-#endif
 
 /* checks to be enabled for "runtime" */
 



More information about the coreboot-gerrit mailing list