[coreboot-gerrit] Patch merged into coreboot/master: veyron_danger: Enable developer mode switch

gerrit at coreboot.org gerrit at coreboot.org
Thu Jul 9 00:09:01 CEST 2015


the following patch was just integrated into master:
commit cc74221581f0b21dcf288532267da01680eb9cc1
Author: David Hendricks <dhendrix at chromium.org>
Date:   Wed Jun 3 16:40:16 2015 -0700

    veyron_danger: Enable developer mode switch
    
    Danger has a physical developer mode switch, it was just never
    set up. This patch defines it, sets it up in fill_lb_gpios(),
    and disables VIRTUAL_DEV_SWITCH.
    
    Note: For now at least, dev mode is a bit wonky on Danger. It's
    connected to both a DIP switch and a button. The button is normally
    open, pulling dev mode high (defaulting to ON). The switch's "ON"
    position will pull the value low, so we invert the value in coreboot
    to see the expected behavior. Dev mode is enabled by holding the
    button down during boot or by setting switch 2 in the DIP bank to
    the ON position.
    
    BUG=none
    BRANCH=none
    TEST=toggled dev switch on Danger and saw dev screen show up (or
    not) as expected
    
    Change-Id: I9369b96b6c9b54553d969b919ed663abdc704dd2
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: dce53f1a31919f15f6e46c4a7d1c5ce541c2b318
    Original-Change-Id: I737f165d7704e2f73375099367f012b365e3e77d
    Original-Signed-off-by: David Hendricks <dhendrix at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/280852
    Original-Reviewed-by: Julius Werner <jwerner at chromium.org>
    Reviewed-on: http://review.coreboot.org/10839
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/10839 for details.

-gerrit



More information about the coreboot-gerrit mailing list