[coreboot-gerrit] New patch to review for coreboot: toolchain.inc: Don't overwrite architecture specific CFLAGS

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Tue Jul 7 23:38:53 CEST 2015


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10831

-gerrit

commit 4efa914648264a51bf5784155eb66b93e51a1f0d
Author: Stefan Reinauer <stefan.reinauer at coreboot.org>
Date:   Tue Jul 7 23:37:11 2015 +0200

    toolchain.inc: Don't overwrite architecture specific CFLAGS
    
    For almost all platforms the CFLAGS_<arch> specified in .xcompile
    were overwritten by toolchain.inc, effectively breaking the build
    in different places and in subtle ways.
    
    Change-Id: I8e1db0eee7ca417ec56ed2156ae1b0b318e57e81
    Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
---
 toolchain.inc | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/toolchain.inc b/toolchain.inc
index a26da47..3e28bb9 100644
--- a/toolchain.inc
+++ b/toolchain.inc
@@ -62,17 +62,17 @@ ARCHDIR-arm64	:= arm64
 ARCHDIR-riscv	:= riscv
 ARCHDIR-mips	:= mips
 
-CFLAGS_arm      := -ffunction-sections -fdata-sections
+CFLAGS_arm      += -ffunction-sections -fdata-sections
 
-CFLAGS_arm64    := -ffunction-sections -fdata-sections
+CFLAGS_arm64    += -ffunction-sections -fdata-sections
 
-CFLAGS_mips	:= -mips32r2 -G 0  -ffunction-sections -fdata-sections
+CFLAGS_mips	+= -mips32r2 -G 0  -ffunction-sections -fdata-sections
 CFLAGS_mips	+= -mno-abicalls -fno-pic
 
 CFLAGS_x86_32 += -ffunction-sections -fdata-sections
-CFLAGS_riscv	:= -ffunction-sections -fdata-sections
+CFLAGS_riscv	+= -ffunction-sections -fdata-sections
 
-CFLAGS_x86_64   := -mcmodel=large
+CFLAGS_x86_64   += -mcmodel=large
 
 toolchain_to_dir = \
 	$(foreach arch,$(ARCH_SUPPORTED),\



More information about the coreboot-gerrit mailing list