[coreboot-gerrit] Patch merged into coreboot/master: Unconditionally compile romstage with -Wa, --divide

gerrit at coreboot.org gerrit at coreboot.org
Tue Jul 7 17:40:11 CEST 2015


the following patch was just integrated into master:
commit 4c8fa2aad28fa5290478317a99e1323ade714677
Author: Stefan Reinauer <stefan.reinauer at coreboot.org>
Date:   Tue Jul 7 00:32:47 2015 +0200

    Unconditionally compile romstage with -Wa,--divide
    
    The option --divide is required by our assembler to ensure that
    '/' is not parsed as a comment sign but as a division, because
    some of the cache as ram code is using divisions.
    
    The --divide parameter has been part of the GNU as since binutils 2.17.
    Hence, compile romstage (which contains cache as ram init) with
    -Wa,--divide unconditionally instead of probing for it and adding it to
    all compiler invocations (because that is causing random trouble with
    clang when compiling the SMM code and calling gcc with --divide instead of
    -Wa,--divide)
    
    Change-Id: Ideefb2a243dc1d657ba415a99c1f8ab1d93800e0
    Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
    Reviewed-on: http://review.coreboot.org/10817
    Tested-by: build bot (Jenkins)
    Reviewed-by: Patrick Georgi <pgeorgi at google.com>


See http://review.coreboot.org/10817 for details.

-gerrit



More information about the coreboot-gerrit mailing list