[coreboot-gerrit] Patch merged into coreboot/master: Revert "sandy/ivybridge: use LAPIC timer in SMM"

gerrit at coreboot.org gerrit at coreboot.org
Mon Jul 6 22:13:09 CEST 2015


the following patch was just integrated into master:
commit 5a2bd0b69313aabcff7e7965494429c0b8dbdda4
Author: Patrick Georgi <pgeorgi at chromium.org>
Date:   Mon Jul 6 18:18:22 2015 +0200

    Revert "sandy/ivybridge: use LAPIC timer in SMM"
    
    This reverts commit a3aa8da2acec28670b724b7897ae054592746674.
    
    Chrome OS builds require the monotonic timer API in SMM for ELOG_GSMI,
    but sandy/ivy doesn't provide it. The commit tried to work around that
    by using generic LAPIC code instead, but this leads to multiple
    definition errors in other configurations (and it may be unreliable once
    the OS reconfigured the APIC timers anyhow).
    
    This fixes the situation for the non-ELOG_GSMI case (which is more or
    less everybody but Chrome OS). ELOG_GSMI requires a separate fix.
    
    Change-Id: If4d69a122b020e5b2d2316b8da225435f6b2bef0
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Reviewed-on: http://review.coreboot.org/10811
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
    Tested-by: build bot (Jenkins)
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>


See http://review.coreboot.org/10811 for details.

-gerrit



More information about the coreboot-gerrit mailing list