[coreboot-gerrit] New patch to review for coreboot: veyron_brain: Add basic HDMI support

[Patrick Georgi (pgeorgi@google.com)]

Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10778

-gerrit

commit 125db64cf564754cdfff08ac0fd23f596ba22e43
Author: David Hendricks <dhendrix at chromium.org>
Date:   Thu Jun 25 16:59:02 2015 -0700

    veyron_brain: Add basic HDMI support
    
    This adds a configure_hdmi() function that drives the HDMI
    enable output high and configures the iomux. Calls to PMIC
    functions to enable HDMI power are moved here as well.
    
    BUG=none
    BRANCH=none
    TEST=with follow-up patches, we now get a dev screen on Brain.
    
    Change-Id: Ifd2648376c789fb29c9e2e4ab6bdb10ca439e4a2
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 91ec6a96edaf2042236aee0383e18715014f1013
    Original-Change-Id: I0c6e9f8fc5e06f53a1a160d8ab2e32447168139e
    Original-Signed-off-by: David Hendricks <dhendrix at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/282046
---
 src/mainboard/google/veyron_brain/devicetree.cb |  1 +
 src/mainboard/google/veyron_brain/mainboard.c   | 11 +++++++++++
 2 files changed, 12 insertions(+)

diff --git a/src/mainboard/google/veyron_brain/devicetree.cb b/src/mainboard/google/veyron_brain/devicetree.cb
index 4c2ea8f..3ed746c 100644
--- a/src/mainboard/google/veyron_brain/devicetree.cb
+++ b/src/mainboard/google/veyron_brain/devicetree.cb
@@ -21,5 +21,6 @@
 chip soc/rockchip/rk3288
 	device cpu_cluster 0 on end
 	register "vop_id" = "1"
+	register "vop_mode" = "VOP_MODE_HDMI"
 	register "framebuffer_bits_per_pixel" = "16"
 end
diff --git a/src/mainboard/google/veyron_brain/mainboard.c b/src/mainboard/google/veyron_brain/mainboard.c
index a5c40c23..29f66e3 100644
--- a/src/mainboard/google/veyron_brain/mainboard.c
+++ b/src/mainboard/google/veyron_brain/mainboard.c
@@ -76,10 +76,20 @@ static void configure_vop(void)
 
 	/* lcdc(vop) iodomain select 1.8V */
 	write32(&rk3288_grf->io_vsel, RK_SETBITS(1 << 0));
+}
 
+static void configure_hdmi(void)
+{
 	rk808_configure_switch(2, 1);	/* VCC18_LCD (HDMI_AVDD_1V8) */
 	rk808_configure_ldo(7, 1000);	/* VDD10_LCD (HDMI_AVDD_1V0) */
 	rk808_configure_switch(1, 1);	/* VCC33_LCD */
+
+	/* set POWER_HDMI_ON */
+	gpio_output(GPIO(7, A, 2), 1);
+
+	/* HDMI I2C */
+	write32(&rk3288_grf->iomux_i2c5sda, IOMUX_HDMI_EDP_I2C_SDA);
+	write32(&rk3288_grf->iomux_i2c5scl, IOMUX_HDMI_EDP_I2C_SCL);
 }
 
 static void mainboard_init(device_t dev)
@@ -90,6 +100,7 @@ static void mainboard_init(device_t dev)
 	configure_emmc();
 	configure_codec();
 	configure_vop();
+	configure_hdmi();
 
 	elog_init();
 	elog_add_watchdog_reset();