[coreboot-gerrit] New patch to review for coreboot: veyron_danger: EDP changes for v2

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Fri Jul 3 16:35:25 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10771

-gerrit

commit 2b0eae79891b03612202ed07922b65d79000e565
Author: David Hendricks <dhendrix at chromium.org>
Date:   Mon Jun 1 15:17:24 2015 -0700

    veyron_danger: EDP changes for v2
    
    EDP-related hardware modifications for v2:
    - BL_EN moved from GPIO7_A3 to GPIO7_A2
    - EDP_HPD added to GPIO7_B3
    
    BUG=none
    BRANCH=none
    TEST=built and booted Danger v2 with EDP panel attached, saw dev
    mode screen come up
    
    Change-Id: I47383610082b371a612aced656e56f1bd1cfa098
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: fb939ff17cca7bbd24aabfdb3cbd444696a5a845
    Original-Signed-off-by: David Hendricks <dhendrix at chromium.org>
    Original-Change-Id: Id271cdcfcde6fa84c1bb707b9842bddd77a7121b
    Original-Reviewed-on: https://chromium-review.googlesource.com/280855
    Original-Reviewed-by: Julius Werner <jwerner at chromium.org>
---
 src/mainboard/google/veyron_danger/mainboard.c | 26 ++++++++++++++++++++++++--
 1 file changed, 24 insertions(+), 2 deletions(-)

diff --git a/src/mainboard/google/veyron_danger/mainboard.c b/src/mainboard/google/veyron_danger/mainboard.c
index 7b06742..f105d36 100644
--- a/src/mainboard/google/veyron_danger/mainboard.c
+++ b/src/mainboard/google/veyron_danger/mainboard.c
@@ -99,10 +99,32 @@ static void configure_vop(void)
 	 * To minimize display corruption, turn off LCDC_BL before
 	 * powering on the backlight.
 	 */
-	gpio_output(GPIO_BACKLIGHT, 1);	/* BL_EN */
-	gpio_output(GPIO_LCDC_BL, 0);
+	switch (board_id()) {
+	case 0:
+		gpio_output(GPIO(7, A, 3), 1);
+		break;
+	default:
+		gpio_output(GPIO(7, A, 2), 1);
+		break;
+	}
 
+	gpio_output(GPIO_LCDC_BL, 0);
 	rk808_configure_switch(1, 1);	/* VCC33_LCD */
+
+	/* EDP_HPD setup */
+	switch (board_id()) {
+	case 0:
+		/* not present */
+		break;
+	default:
+		/* Unlike other Veyrons, Danger has external pull resistors on
+		 * EDP_HPD. Default for GPIO(7, B, 3) is pull-down, set to
+		 * float.
+		 */
+		gpio_input(GPIO(7, B, 3));
+		write32(&rk3288_grf->iomux_edp_hotplug, IOMUX_EDP_HOTPLUG);
+		break;
+	}
 }
 
 static void configure_hdmi(void)



More information about the coreboot-gerrit mailing list