[coreboot-gerrit] New patch to review for coreboot: 70786de winent/mb6047: use symbolic constant arguments for acpi_create_madt_lapic_nmis()

Jonathan A. Kollasch (jakllsch@kollasch.net) gerrit at coreboot.org
Sat Jan 31 21:27:45 CET 2015


Jonathan A. Kollasch (jakllsch at kollasch.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8317

-gerrit

commit 70786deb4cb1e9476eb33104730ce45f4d70342c
Author: Jonathan A. Kollasch <jakllsch at kollasch.net>
Date:   Sat Jan 31 14:18:55 2015 -0600

    winent/mb6047: use symbolic constant arguments for acpi_create_madt_lapic_nmis()
    
    Change-Id: I19af5f36a55d6c2906d603e940b3aadd2ca97140
    Signed-off-by: Jonathan A. Kollasch <jakllsch at kollasch.net>
---
 src/mainboard/winent/mb6047/acpi_tables.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/mainboard/winent/mb6047/acpi_tables.c b/src/mainboard/winent/mb6047/acpi_tables.c
index fdf2d80..63b41f0 100644
--- a/src/mainboard/winent/mb6047/acpi_tables.c
+++ b/src/mainboard/winent/mb6047/acpi_tables.c
@@ -47,14 +47,10 @@ unsigned long acpi_fill_madt(unsigned long current)
 	current += acpi_create_madt_irqoverride((acpi_madt_irqoverride_t *)
 		current, 0, 9, 9, MP_IRQ_TRIGGER_LEVEL | MP_IRQ_POLARITY_LOW);
 
-	/* 0: mean bus 0--->ISA */
-	/* 0: PIC 0 */
-	/* 2: APIC 2 */
-	/* 5 mean: 0101 --> Edge-triggered, Active high */
-
 	/* create all subtables for processors */
 	/* acpi_create_madt_lapic_nmis returns current, not size. */
-	current = acpi_create_madt_lapic_nmis(current, 5, 1);
+	current = acpi_create_madt_lapic_nmis(current, 
+		MP_IRQ_TRIGGER_EDGE | MP_IRQ_POLARITY_HIGH, 1);
 
 	return current;
 }



More information about the coreboot-gerrit mailing list