[coreboot-gerrit] New patch to review for coreboot: 8a300ce get rid of .car.global_data warnings for GCC build
Martin Roth (gaumless@gmail.com)
gerrit at coreboot.org
Thu Jan 29 04:00:35 CET 2015
Martin Roth (gaumless at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8301
-gerrit
commit 8a300ce3024d4814d449049ef25ed9d91c55f61a
Author: Martin Roth <gaumless at gmail.com>
Date: Thu Jan 22 19:10:10 2015 -0700
get rid of .car.global_data warnings for GCC build
The "used" attribute was added in commit 27cf2472 which caused these
warnings to start appearing when using the standard coreboot GCC
toolchain:
{standard input}: Assembler messages:
{standard input}:96: Warning: ignoring changed section type for .car.global_data
{standard input}:96: Warning: ignoring changed section attributes for
.car.global_data
The # at the end of the section name causes the assembler to ignore
everything following the name. I verified that the resulting binaries
are the same with and without the #.
Change-Id: Iaac8042533842ed887f33895f083b613a18f496a
Signed-off-by: Martin Roth <gaumless at gmail.com>
---
src/arch/x86/include/arch/early_variables.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/arch/x86/include/arch/early_variables.h b/src/arch/x86/include/arch/early_variables.h
index 2d5ae85..c6727a8 100644
--- a/src/arch/x86/include/arch/early_variables.h
+++ b/src/arch/x86/include/arch/early_variables.h
@@ -23,7 +23,7 @@
#ifdef __PRE_RAM__
asm(".section .car.global_data,\"w\", at nobits");
asm(".previous");
-#define CAR_GLOBAL __attribute__((used,section(".car.global_data")))
+#define CAR_GLOBAL __attribute__((used,section(".car.global_data#")))
#else
#define CAR_GLOBAL
#endif
More information about the coreboot-gerrit
mailing list