[coreboot-gerrit] Patch set updated for coreboot: 9f10e7b nvidia/ck804: Fix FTBFS with AMD Family 10h systems

Timothy Pearson (tpearson@raptorengineeringinc.com) gerrit at coreboot.org
Wed Jan 28 01:06:03 CET 2015


Timothy Pearson (tpearson at raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8269

-gerrit

commit 9f10e7b49768b3f46704b181ccbfb7831cf2f8b7
Author: Timothy Pearson <tpearson at raptorengineeringinc.com>
Date:   Fri Jan 23 20:29:46 2015 -0600

    nvidia/ck804: Fix FTBFS with AMD Family 10h systems
    
    The build failure stems from a missing function being called via a chain
    including setup_ss_table(), set_ht_link_ck804(), and
    st_ht_link_buffer_counts_chain(); the latter function is only available\
    in the AMD K8 code.
    
    It appears that a bunch of K8-specific code snuck into the CK804 and MCP55
    southbridge code in GIT hashes 968bbe89 and d4b278c0.
    
    Change-Id: I85d005edba44c503c49917d4b928e5c9c5900059
    Signed-off-by: Timothy Pearson <tpearson at raptorengineeringinc.com>
---
 src/southbridge/nvidia/ck804/early_setup_car.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/southbridge/nvidia/ck804/early_setup_car.c b/src/southbridge/nvidia/ck804/early_setup_car.c
index 9ba98c9..09cbc58 100644
--- a/src/southbridge/nvidia/ck804/early_setup_car.c
+++ b/src/southbridge/nvidia/ck804/early_setup_car.c
@@ -1,6 +1,8 @@
 /*
  * This file is part of the coreboot project.
  *
+ * Copyright (C) 2015 Timothy Pearson <tpearson at raptorengineeringinc.com>, Raptor Engineering
+ *
  * Copyright (C) 2004 Tyan Computer
  * Written by Yinghai Lu <yhlu at tyan.com> for Tyan Computer.
  *
@@ -18,6 +20,11 @@
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
  */
 
+#if !IS_ENABLED(CONFIG_NORTHBRIDGE_AMD_AMDK8)
+/* Someone messed up and snuck in some K8-specific code */
+static int  set_ht_link_buffer_counts_chain(uint8_t ht_c_num, unsigned vendorid,  unsigned val) { return 0; /* stub */};
+#endif
+
 static int set_ht_link_ck804(u8 ht_c_num)
 {
 	unsigned vendorid = 0x10de;



More information about the coreboot-gerrit mailing list