[coreboot-gerrit] New patch to review for coreboot: 210bdc2 toolchain.inc: Check toolchain is installed before running it

Marc Jones (marc.jones@se-eng.com) gerrit at coreboot.org
Thu Jan 22 10:01:32 CET 2015


Marc Jones (marc.jones at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8257

-gerrit

commit 210bdc25e5d06debc93d08cd4b8aea657df9ccf2
Author: Marc Jones <marc.jones at se-eng.com>
Date:   Thu Jan 22 16:18:49 2015 +0800

    toolchain.inc: Check toolchain is installed before running it
    
    Toolchain.inc fails with strange shell errors if the CC_$(stage)
    doesn't expands correctly. The cause is that the ARCH_SUPPORTED
    doesn't have the required toolchain for the stage.
    
    Change-Id: Id284ce281546b2b1b166f2b13d087bc6b114440e
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
---
 toolchain.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/toolchain.inc b/toolchain.inc
index b54d959..90e3c52 100644
--- a/toolchain.inc
+++ b/toolchain.inc
@@ -84,6 +84,7 @@ set_stage_toolchain= \
 # @2: compiler set to be used
 # e.g.: smm special class uses i386 as compiler set
 define create_class_compiler
+$(if $(2),,$(error building $(1) without the required toolchain $(2)))
 CC_$(1) := $(CC_$(2))
 LD_$(1) := $(LD_$(2))
 NM_$(1) := $(NM_$(2))



More information about the coreboot-gerrit mailing list