[coreboot-gerrit] Patch merged into coreboot/master: 337de4c cbmem: Add support for new 'coreboot' compatible device tree binding

gerrit at coreboot.org gerrit at coreboot.org
Tue Jan 13 21:31:52 CET 2015


the following patch was just integrated into master:
commit 337de4c0e539d3d055b916f40fc44067d1a13cd7
Author: Julius Werner <jwerner at chromium.org>
Date:   Mon Jun 16 23:02:03 2014 -0700

    cbmem: Add support for new 'coreboot' compatible device tree binding
    
    This patch brings the cbmem utility in line with the recent change to
    coreboot's device tree binding. Since trying to find the right node to
    place this binding has been so hard (and still isn't quite agreed upon),
    and because it's really the more correct thing to do, this code searches
    through the device tree for the 'coreboot' compatible property instead
    of looking up a hardcoded path. It also provides bullet-proof
    '#address-cells' handling that should work for any endianness and size.
    
    BUG=chrome-os-partner:29311
    TEST=Ran cbmem -c and cbmem -t on Nyan_Big. Also straced the to make
    sure everything looks as expected. 'time cbmem -t' = ~35ms shows that
    there is no serious performance problem from the more thorough lookup
    code.
    
    Original-Change-Id: I806a21270ba6cec6e81232075749016eaf18508b
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/204274
    Original-Reviewed-by: Vadim Bendebury <vbendeb at chromium.org>
    (cherry picked from commit 3e64e28f684e60e8b300906c1abffee75ec6a5c2)
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
    
    Change-Id: I0a0a4f69330d3d8c5c3ea92b55f5dde4d43fca65
    Reviewed-on: http://review.coreboot.org/8141
    Tested-by: build bot (Jenkins)
    Reviewed-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/8141 for details.

-gerrit



More information about the coreboot-gerrit mailing list