[coreboot-gerrit] Patch merged into coreboot/master: 456314f libpayload: Let GDB stub read/write memory with aligned MMIO words
gerrit at coreboot.org
gerrit at coreboot.org
Mon Jan 12 05:56:19 CET 2015
the following patch was just integrated into master:
commit 456314fcf86a1e773a89db3885b035d4a198eb20
Author: Julius Werner <jwerner at chromium.org>
Date: Wed Jul 16 18:39:58 2014 -0700
libpayload: Let GDB stub read/write memory with aligned MMIO words
Looks like we got our first SoC that actually insists on using
word-sized accesses for its MMIO registers with the Rk3288. This patch
changes the GDB command handler for reading and writing memory to always
perform word-sized accesses. This isn't really perfect since the remote
GDB interface is just not really meant to interact with MMIO (e.g. you
shouldn't use this on something with read side effects), but for most
of our purposes it should be good enough.
BUG=chrome-os-partner:18390
TEST=Remote GDB works on Veyron even when writing MMIO registers.
Original-Change-Id: I2ae52636593499f70701582811f1b692c1ea8fcc
Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
Original-Reviewed-on: https://chromium-review.googlesource.com/208554
Original-Reviewed-by: David Hendricks <dhendrix at chromium.org>
(cherry picked from commit 028940934e6b45a02122b61bb859588bf8671938)
Signed-off-by: Marc Jones <marc.jones at se-eng.com>
Change-Id: I4185a6efe9a5211525781acd0a167b821e854211
Reviewed-on: http://review.coreboot.org/8130
Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
Tested-by: build bot (Jenkins)
See http://review.coreboot.org/8130 for details.
-gerrit
More information about the coreboot-gerrit
mailing list