[coreboot-gerrit] Patch merged into coreboot/master: 22adcd6 libpayload: Introduce new Kconfig to explicitly allow GPL code

gerrit at coreboot.org gerrit at coreboot.org
Fri Jan 9 07:06:30 CET 2015


the following patch was just integrated into master:
commit 22adcd67a27e1a99a743ef26b49ae2afab6fe624
Author: Julius Werner <jwerner at chromium.org>
Date:   Wed Jun 11 14:16:35 2014 -0700

    libpayload: Introduce new Kconfig to explicitly allow GPL code
    
    There have been leaks of GPL code into libpayload for a while now, for
    new features or improvements that require third party code with no
    adequate alternative among BSD-licensed software. It seems silly and
    counter-productive to keep holding back features and performance
    improvements from libpayload for a use-case (proprietary payloads) that
    doesn't even seem to be implemented anywhere to date. Open-source
    payloads should not need to suffer to appease commercial ones.
    
    Instead, this patch introduces a new Kconfig option to explicitly allow
    inclusion of GPL code. It will use Kconfig dependencies and/or Makefile
    rules to ensure that no GPL code can end up in the final payload if that
    option is unset, allowing proprietary payloads to keep working with the
    existing BSD-licensed feature set. New features and patches (that are
    sufficiently separate and self-contained to allow guarding through this
    config option) can choose whether to import GPL code, and need to depend
    on this option if they do.
    
    Also clean up all (known) existing uses of GPL code to depend on the new
    option, add some recent third-party imports to the LICENSES file, and
    relicense the selfboot.c files to BSD with permission of the author.
    
    BUG=chrome-os-partner:24957
    TEST=Compiled Falco and Nyan_Big both with and without the new option,
    disassembled output binaries to ensure that memcpy() looks as expected.
    
    Original-Change-Id: I6e3a75b1a8e46291c75a876844c7a01f7d3f2a0e
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Signed-off-by: Hung-Te Lin <hungte at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/203513
    Original-Reviewed-by: Stefan Reinauer <reinauer at chromium.org>
    (cherry picked from commit d8e5a9fdf583b5ac861f34baea6a16c4d8536512)
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
    
    Change-Id: I446fef028264c793b946dd9f765e446bf708b4db
    Reviewed-on: http://review.coreboot.org/8118
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>


See http://review.coreboot.org/8118 for details.

-gerrit



More information about the coreboot-gerrit mailing list