[coreboot-gerrit] New patch to review for coreboot: c1f6faf src/device: Doxygen fixes

[Martin Roth (gaumless@gmail.com)]

Martin Roth (gaumless at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8173

-gerrit

commit c1f6fafbe5641fa3d65b5ab0f7ec50219faeed6e
Author: Martin Roth <gaumless at gmail.com>
Date:   Tue Jan 6 21:02:52 2015 -0700

    src/device: Doxygen fixes
    
    - Add missing parameters
    - add missing @param commands
    
    Change-Id: I029b5dafde94bd250800b06c0e9bd2118f10ef48
    Signed-off-by: Martin Roth <gaumless at gmail.com>
---
 src/device/dram/ddr3.c  | 11 ++++++++++-
 src/device/pci_device.c |  4 ++--
 2 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/src/device/dram/ddr3.c b/src/device/dram/ddr3.c
index 86abea8..8170ae1 100644
--- a/src/device/dram/ddr3.c
+++ b/src/device/dram/ddr3.c
@@ -18,7 +18,7 @@
  */
 
 /**
- * @file ddr3_util.h
+ * @file ddr3.c
  *
  * \brief Utilities for decoding DDR3 SPDs
  */
@@ -452,8 +452,13 @@ static u16 ddr3_cas_to_mr0_map(u8 cas)
  * write_recovery and cas are given in clock cycles. For example, a CAS of 7T
  * should be given as 7.
  *
+ * @param precharge_pd
  * @param write_recovery Write recovery latency, tWR in clock cycles.
+ * @param dll_reset
+ * @param mode
  * @param cas CAS latency in clock cycles.
+ * @param burst_type
+ * @param burst_length
  */
 mrs_cmd_t ddr3_get_mr0(enum ddr3_mr0_precharge precharge_pd,
 		       u8 write_recovery,
@@ -555,8 +560,12 @@ mrs_cmd_t ddr3_get_mr1(enum ddr3_mr1_qoff qoff,
  * cas_cwl is given in clock cycles. For example, a cas_cwl of 7T should be
  * given as 7.
  *
+ * @param rtt_wr
+ * @param extended_temp
+ * @param self_refresh
  * @param cas_cwl CAS write latency in clock cycles.
  */
+
 mrs_cmd_t ddr3_get_mr2(enum ddr3_mr2_rttwr rtt_wr,
 		       enum ddr3_mr2_srt_range extended_temp,
 		       enum ddr3_mr2_asr self_refresh, u8 cas_cwl)
diff --git a/src/device/pci_device.c b/src/device/pci_device.c
index 22454d6..862ed0e 100644
--- a/src/device/pci_device.c
+++ b/src/device/pci_device.c
@@ -818,8 +818,8 @@ static struct device_operations *get_pci_bridge_ops(device_t dev)
  * The driver entry can either point at a zero terminated array of acceptable
  * device IDs, or include a single device ID.
  *
- * @driver pointer to the PCI driver entry being checked
- * @device_id PCI device ID of the device being matched
+ * @param driver pointer to the PCI driver entry being checked
+ * @param device_id PCI device ID of the device being matched
  */
 static int device_id_match(struct pci_driver *driver, unsigned short device_id)
 {