[coreboot-gerrit] New patch to review for coreboot: c0aebd7 mainboard/packardbell/ms2290/romstage.c: Comment unused func

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Wed Jan 7 16:07:13 CET 2015


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8167

-gerrit

commit c0aebd7daac48acc7f280ac215362d673dd4f19d
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Thu Jan 8 01:57:43 2015 +1100

    mainboard/packardbell/ms2290/romstage.c: Comment unused func
    
    Take unused reverse eng function out of build by wrapping in #if 0.
    
    Change-Id: I816b3ea08a8858fc03e4455c1d7711265e63cba4
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/mainboard/packardbell/ms2290/romstage.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/mainboard/packardbell/ms2290/romstage.c b/src/mainboard/packardbell/ms2290/romstage.c
index a366d38..f702e9f 100644
--- a/src/mainboard/packardbell/ms2290/romstage.c
+++ b/src/mainboard/packardbell/ms2290/romstage.c
@@ -163,10 +163,13 @@ static inline u32 read_acpi32(u32 addr)
 	return inl(DEFAULT_PMBASE | addr);
 }
 
+// unused func - used for RE
+#if 0
 static inline u16 read_acpi16(u32 addr)
 {
 	return inw(DEFAULT_PMBASE | addr);
 }
+#endif
 
 #include <cpu/intel/romstage.h>
 void main(unsigned long bist)



More information about the coreboot-gerrit mailing list