[coreboot-gerrit] Patch set updated for coreboot: 6f52fd7 hudson: reintroduce HUDSON_DISABLE_IMC option

Felix Held (felix-coreboot@felixheld.de) gerrit at coreboot.org
Wed Jan 7 10:47:41 CET 2015


Felix Held (felix-coreboot at felixheld.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8089

-gerrit

commit 6f52fd7ad8520ce9fde74a6e54aec40ebb8369dc
Author: Felix Held <felix-coreboot at felixheld.de>
Date:   Sun Jan 4 17:19:59 2015 +0100

    hudson: reintroduce HUDSON_DISABLE_IMC option
    
    HUDSON_DISABLE_IMC was introduced in commit 1a59039c
    option gets used in commit 99799d66 for asus/f2a85-m
    option gets killed in commit 1b1b795f, but is still used in source agesa based
    boards (asus/f2a85-m and asus/f2a85-m_le)
    
    The HUDSON_DISABLE_IMC option is reintroduced to exclude the IMC firmware on
    boards where the fan control is done by the SIO/EC and not by the FCH.
    
    Defaulting HUDSON_IMC_FWM to n, making it depend on USE_BLOBS and explicitly
    sourcing it in the board Kconfig file does not work as expected; when we
    explicitly select HUDSON_IMC_FWM in the mainboard Kconfig and USE_BLOBS is n,
    we get a warning due to unmet dependencies, but the IMC firmware still gets
    included in CBFS.
    
    Change-Id: I448a0dc7c9fef504f89cfd192ca74172425fb3e0
    Signed-off-by: Felix Held <felix-coreboot at felixheld.de>
---
 src/southbridge/amd/agesa/hudson/Kconfig | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/southbridge/amd/agesa/hudson/Kconfig b/src/southbridge/amd/agesa/hudson/Kconfig
index acc2d72..f957c48 100644
--- a/src/southbridge/amd/agesa/hudson/Kconfig
+++ b/src/southbridge/amd/agesa/hudson/Kconfig
@@ -59,8 +59,13 @@ config HUDSON_XHCI_FWM
 	help
 	  Add Hudson 2/3/4 XHCI Firmware to support the onboard USB 3.0
 
+config HUDSON_DISABLE_IMC
+	bool
+	default n
+
 config HUDSON_IMC_FWM
 	bool "Add imc firmware"
+	depends on !HUDSON_DISABLE_IMC
 	default y if USE_BLOBS
 	help
 	  Add Hudson 2/3/4 IMC Firmware to support the onboard fan control



More information about the coreboot-gerrit mailing list