[coreboot-gerrit] New patch to review for coreboot: 46e7a96 storm: USB fixes for proto0

Marc Jones (marc.jones@se-eng.com) gerrit at coreboot.org
Wed Jan 7 00:05:34 CET 2015


Marc Jones (marc.jones at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8147

-gerrit

commit 46e7a9675048253327145076d66d36c2194b134e
Author: Vadim Bendebury <vbendeb at chromium.org>
Date:   Tue Jun 24 07:26:03 2014 -0700

    storm: USB fixes for proto0
    
    The actual storm device has a single USB interface, which needs to be
    explicitly turned on using GPIO51.
    
    BUG=chrome-os-partner:29871
    TEST=verified that depthcharge finds and boots a kernel from USB stick
    
    Original-Change-Id: Iaf868812c96e1e3289b9403855c4cc8f87c1e368
    Original-Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/205329
    Original-Reviewed-by: Stefan Reinauer <reinauer at chromium.org>
    Original-Reviewed-by: Trevor Bourget <tbourget at codeaurora.org>
    (cherry picked from commit aa22376ffac22309a298dfa844e7f61c97d57d3e)
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
    
    Change-Id: Ic0f34622e61a65a0540c0f3fca26fb057fa85fb7
---
 src/mainboard/google/storm/mainboard.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/google/storm/mainboard.c b/src/mainboard/google/storm/mainboard.c
index 301e645..d5adf2d 100644
--- a/src/mainboard/google/storm/mainboard.c
+++ b/src/mainboard/google/storm/mainboard.c
@@ -21,6 +21,7 @@
 #include <boot/coreboot_tables.h>
 #include <device/device.h>
 #include <soc/qualcomm/ipq806x/include/clock.h>
+#include <soc/qualcomm/ipq806x/include/gpio.h>
 #include <soc/qualcomm/ipq806x/include/usb.h>
 
 /* convenient shorthand (in MB) */
@@ -32,12 +33,15 @@
 #define DMA_START            (CONFIG_DRAM_DMA_START / MiB)
 #define DMA_SIZE             (CONFIG_DRAM_DMA_SIZE / MiB)
 
+#define USB_ENABLE_GPIO		51
+
 static void setup_usb(void)
 {
+	gpio_tlmm_config_set(USB_ENABLE_GPIO, FUNC_SEL_GPIO,
+			     GPIO_PULL_UP, GPIO_10MA, GPIO_ENABLE);
 	usb_clock_config();
 
 	setup_usb_host1();
-	setup_usb_host2();
 }
 
 static void setup_mmu(void)



More information about the coreboot-gerrit mailing list