[coreboot-gerrit] Patch set updated for coreboot: 2b2575c superio: Drop print_ implementation from non-romcc boards
Stefan Reinauer (stefan.reinauer@coreboot.org)
gerrit at coreboot.org
Tue Jan 6 18:25:23 CET 2015
Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8113
-gerrit
commit 2b2575c9c4961a9a2dab93d331d3e8526033c7f7
Author: Stefan Reinauer <reinauer at chromium.org>
Date: Mon Jan 5 13:05:44 2015 -0800
superio: Drop print_ implementation from non-romcc boards
Because we had no stack on romcc boards, we had a separate, not as
powerful clone of printk: print_*. Back in the day, like more than
half a decade ago, we migrated a lot of boards to printk, but we never
cleaned up the existing code to be consistent. instead, we worked around
the problem with a very messy console.h (nowadays the mess is hidden in
romstage_console.c and early_print.h)
This patch cleans up the superio code to use printk() on all non-ROMCC
boards.
Change-Id: I23fc307f1346cdb7adaaeccfafe17d9205e909ac
Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
---
src/superio/serverengines/pilot/early_init.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/superio/serverengines/pilot/early_init.c b/src/superio/serverengines/pilot/early_init.c
index 6635645..b609572 100644
--- a/src/superio/serverengines/pilot/early_init.c
+++ b/src/superio/serverengines/pilot/early_init.c
@@ -36,11 +36,9 @@ void pilot_early_init(pnp_devfn_t dev)
{
u16 port = dev >> 8;
- print_debug("Using port: ");
- print_debug_hex16(port);
- print_debug("\n");
+ printk(BIOS_DEBUG, "Using port: %04x\n", port);
pilot_disable_serial(PNP_DEV(port, 0x1));
- print_debug("disable serial 1\n");
+ printk(BIOS_DEBUG, "disable serial 1\n");
pnp_enter_ext_func_mode(dev);
pnp_set_logical_device(PNP_DEV(port, 0x3));
More information about the coreboot-gerrit
mailing list