[coreboot-gerrit] Patch set updated for coreboot: 9957f30 superio/smsc/lpc47n217: Drop dead code

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Mon Jan 5 23:10:23 CET 2015


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8112

-gerrit

commit 9957f30254d6b5f66eac3b23aedf8d908aaa005d
Author: Stefan Reinauer <reinauer at chromium.org>
Date:   Mon Jan 5 13:03:43 2015 -0800

    superio/smsc/lpc47n217: Drop dead code
    
    This code is unused, and the same functionality is in superiotool
    already.
    
    Change-Id: I7bf667e2e2bfc8fdedcdbe09bf420abf47b1ee97
    Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
---
 src/superio/smsc/lpc47n217/superio.c | 40 ------------------------------------
 1 file changed, 40 deletions(-)

diff --git a/src/superio/smsc/lpc47n217/superio.c b/src/superio/smsc/lpc47n217/superio.c
index 96dd4e2..85de359 100644
--- a/src/superio/smsc/lpc47n217/superio.c
+++ b/src/superio/smsc/lpc47n217/superio.c
@@ -276,43 +276,3 @@ static void pnp_exit_conf_state(struct device *dev)
 {
 	outb(0xaa, dev->path.pnp.port);
 }
-
-#if 0
-/**
- * Print the values of all of the LPC47N217's configuration registers.
- *
- * NOTE: The LPC47N217 must be in config mode when this function is called.
- *
- * @param dev Pointer to structure describing a Super I/O device.
- */
-static void dump_pnp_device(struct device *dev)
-{
-	int i;
-	print_debug("\n");
-
-	for (i = 0; i <= LPC47N217_MAX_CONFIG_REGISTER; i++) {
-		u8 register_value;
-
-		if ((i & 0x0f) == 0) {
-			print_debug_hex8(i);
-			print_debug_char(':');
-		}
-
-		/*
-		 * Skip over 'register' that would cause exit from
-		 * configuration mode.
-		 */
-		if (i == 0xaa)
-			register_value = 0xaa;
-		else
-			register_value = pnp_read_config(dev, i);
-
-		print_debug_char(' ');
-		print_debug_hex8(register_value);
-		if ((i & 0x0f) == 0x0f)
-			print_debug("\n");
-	}
-
-	print_debug("\n");
-}
-#endif



More information about the coreboot-gerrit mailing list