[coreboot-gerrit] New patch to review for coreboot: f14a4ca smihandler.c: Fix doxygen errors in southbridge_smi_handler

Martin Roth (gaumless@gmail.com) gerrit at coreboot.org
Sun Jan 4 05:15:24 CET 2015


Martin Roth (gaumless at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8074

-gerrit

commit f14a4ca4ed1a21a868195167aa07642b762199da
Author: Martin Roth <martin.roth at se-eng.com>
Date:   Mon Dec 29 22:29:08 2014 -0700

    smihandler.c: Fix doxygen errors in southbridge_smi_handler
    
    Correct the param to match the functions.
    
    Change-Id: Id002c549a6ba6a7be4fa5eee396769eaa2510698
    Signed-off-by: Martin Roth <martin.roth at se-eng.com>
---
 src/southbridge/intel/bd82x6x/smihandler.c     | 5 ++---
 src/southbridge/intel/fsp_bd82x6x/smihandler.c | 3 ++-
 src/southbridge/intel/i82801dx/smihandler.c    | 5 ++---
 src/southbridge/intel/i82801gx/smihandler.c    | 4 ++--
 src/southbridge/intel/i82801ix/smihandler.c    | 3 ++-
 src/southbridge/intel/ibexpeak/smihandler.c    | 5 ++---
 src/southbridge/intel/lynxpoint/smihandler.c   | 3 ---
 src/southbridge/intel/sch/smihandler.c         | 5 ++---
 src/southbridge/via/vt8237r/smihandler.c       | 3 ++-
 9 files changed, 16 insertions(+), 20 deletions(-)

diff --git a/src/southbridge/intel/bd82x6x/smihandler.c b/src/southbridge/intel/bd82x6x/smihandler.c
index 1b8810f..45612d0 100644
--- a/src/southbridge/intel/bd82x6x/smihandler.c
+++ b/src/southbridge/intel/bd82x6x/smihandler.c
@@ -819,10 +819,9 @@ static smi_handler_t southbridge_smi[32] = {
 
 /**
  * @brief Interrupt handler for SMI#
- *
- * @param smm_revision revision of the smm state save map
+ * @param node
+ * @param state_save
  */
-
 void southbridge_smi_handler(unsigned int node, smm_state_save_area_t *state_save)
 {
 	int i, dump = 0;
diff --git a/src/southbridge/intel/fsp_bd82x6x/smihandler.c b/src/southbridge/intel/fsp_bd82x6x/smihandler.c
index 493a98e..c98e267 100644
--- a/src/southbridge/intel/fsp_bd82x6x/smihandler.c
+++ b/src/southbridge/intel/fsp_bd82x6x/smihandler.c
@@ -754,7 +754,8 @@ static smi_handler_t southbridge_smi[32] = {
 /**
  * @brief Interrupt handler for SMI#
  *
- * @param smm_revision revision of the smm state save map
+ * @param node
+ * @param state_save
  */
 
 void southbridge_smi_handler(unsigned int node, smm_state_save_area_t *state_save)
diff --git a/src/southbridge/intel/i82801dx/smihandler.c b/src/southbridge/intel/i82801dx/smihandler.c
index 9b0c235..e5a3282 100644
--- a/src/southbridge/intel/i82801dx/smihandler.c
+++ b/src/southbridge/intel/i82801dx/smihandler.c
@@ -610,10 +610,9 @@ smi_handler_t southbridge_smi[32] = {
 
 /**
  * @brief Interrupt handler for SMI#
- *
- * @param smm_revision revision of the smm state save map
+ * @param node
+ * @param state_save
  */
-
 void southbridge_smi_handler(unsigned int node, smm_state_save_area_t *state_save)
 {
 	int i, dump = 0;
diff --git a/src/southbridge/intel/i82801gx/smihandler.c b/src/southbridge/intel/i82801gx/smihandler.c
index 4959c4d..e2505ce 100644
--- a/src/southbridge/intel/i82801gx/smihandler.c
+++ b/src/southbridge/intel/i82801gx/smihandler.c
@@ -610,8 +610,8 @@ smi_handler_t southbridge_smi[32] = {
 
 /**
  * @brief Interrupt handler for SMI#
- *
- * @param smm_revision revision of the smm state save map
+ * @param node
+ * @param state_save
  */
 
 void southbridge_smi_handler(unsigned int node, smm_state_save_area_t *state_save)
diff --git a/src/southbridge/intel/i82801ix/smihandler.c b/src/southbridge/intel/i82801ix/smihandler.c
index 6d17621..45a09df 100644
--- a/src/southbridge/intel/i82801ix/smihandler.c
+++ b/src/southbridge/intel/i82801ix/smihandler.c
@@ -493,7 +493,8 @@ static u32 southbrigde_smi_mask_events(u32 smi_sts)
 /**
  * @brief Interrupt handler for SMI#
  *
- * @param smm_revision revision of the smm state save map
+ * @param node
+ * @param *state_save
  */
 void southbridge_smi_handler(unsigned int node, smm_state_save_area_t *state_save)
 {
diff --git a/src/southbridge/intel/ibexpeak/smihandler.c b/src/southbridge/intel/ibexpeak/smihandler.c
index b6ca523..e2032ad 100644
--- a/src/southbridge/intel/ibexpeak/smihandler.c
+++ b/src/southbridge/intel/ibexpeak/smihandler.c
@@ -819,10 +819,9 @@ static smi_handler_t southbridge_smi[32] = {
 
 /**
  * @brief Interrupt handler for SMI#
- *
- * @param smm_revision revision of the smm state save map
+ * @param node
+ * @param state_save
  */
-
 void southbridge_smi_handler(unsigned int node, smm_state_save_area_t *state_save)
 {
 	int i, dump = 0;
diff --git a/src/southbridge/intel/lynxpoint/smihandler.c b/src/southbridge/intel/lynxpoint/smihandler.c
index 627c64f..bb13c98 100644
--- a/src/southbridge/intel/lynxpoint/smihandler.c
+++ b/src/southbridge/intel/lynxpoint/smihandler.c
@@ -517,10 +517,7 @@ static smi_handler_t southbridge_smi[32] = {
 
 /**
  * @brief Interrupt handler for SMI#
- *
- * @param smm_revision revision of the smm state save map
  */
-
 void southbridge_smi_handler(void)
 {
 	int i;
diff --git a/src/southbridge/intel/sch/smihandler.c b/src/southbridge/intel/sch/smihandler.c
index 5074138..57117c6 100644
--- a/src/southbridge/intel/sch/smihandler.c
+++ b/src/southbridge/intel/sch/smihandler.c
@@ -267,10 +267,9 @@ void southbridge_smi_set_eos(void)
 
 /**
  * @brief Interrupt handler for SMI#
- *
- * @param smm_revision revision of the smm state save map
+ * @param node
+ * @param state_save
  */
-
 void southbridge_smi_handler(unsigned int node, smm_state_save_area_t *state_save)
 {
 // FIXME: the necessary magic isn't available yet. the code
diff --git a/src/southbridge/via/vt8237r/smihandler.c b/src/southbridge/via/vt8237r/smihandler.c
index 454636f..17cc37a 100644
--- a/src/southbridge/via/vt8237r/smihandler.c
+++ b/src/southbridge/via/vt8237r/smihandler.c
@@ -216,7 +216,8 @@ smi_handler_t southbridge_smi[32] = {
 /**
  * @brief Interrupt handler for SMI#
  *
- * @param smm_revision revision of the smm state save map
+ * @param node
+ * @param state_save revision of the smm state save map
  */
 
 void southbridge_smi_handler(unsigned int node, smm_state_save_area_t *state_save)



More information about the coreboot-gerrit mailing list