[coreboot-gerrit] Patch merged into coreboot/master: 15c98b0 storm/ipq8064: add dynamic CBMEM support

gerrit at coreboot.org gerrit at coreboot.org
Sat Jan 3 04:59:30 CET 2015


the following patch was just integrated into master:
commit 15c98b021771d10c4bb98e5b0e8cb910cd0c1f7d
Author: Vadim Bendebury <vbendeb at chromium.org>
Date:   Thu May 1 14:45:56 2014 -0700

    storm/ipq8064: add dynamic CBMEM support
    
    Squashed the correction patch with the original to avoid confusion in
    coreboot.org review.
    
    All what's needed apart from configuring the feature is to provide a
    function which would report the top of DRAM address.
    
    BUG=chrome-os-partner:27784
    TEST=manual
      . with all other patches applied, the image proceeds all the way to
        trying to download 'fallback/payload'.
    
    Original-Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
    Original-Change-Id: Ifa586964c931976df1dff354066670463f8e9ee3
    Original-Reviewed-on: https://chromium-review.googlesource.com/197897
    (cherry picked from commit 54fed275fe80dee66d423ddd78a071d3f063464a)
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
    
    storm: initialize dynamic cbmem properly
    
    Dynamic cbmem support has been enabled on storm, but the proper
    initialization at romstage is missing.
    
    Proper DRAM base address definition is also necessary so that CBMEM is
    placed in the correct address range (presently at the top of DRAM).
    
    BUG=chrome-os-partner:27784
    
    TEST=build boot coreboot on ap148, observe the following in the
         console output:
    
      Wrote coreboot table at: 5fffd000, 0xe8 bytes, checksum 44a5
      coreboot table: 256 bytes.
      CBMEM ROOT  0. 5ffff000 00001000
      COREBOOT    1. 5fffd000 00002000
    
    Original-Change-Id: I74ccd252ddfdeaa0a5bcc929be72be174f310730
    Original-Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/199674
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    (cherry picked from commit e2aeb2f4e7f3959d5f5336f42a29909134a7ddb7)
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
    
    Change-Id: I45f7016dd510fe0e924b63eb85da607c1652af74
    Reviewed-on: http://review.coreboot.org/7996
    Tested-by: build bot (Jenkins)
    Reviewed-by: Kyösti Mälkki <kyosti.malkki at gmail.com>


See http://review.coreboot.org/7996 for details.

-gerrit



More information about the coreboot-gerrit mailing list