[coreboot-gerrit] New patch to review for coreboot: aa17dca northbridge/amd/agesa/familyXY: Make NULL device op explicit

[Edward O'Callaghan (eocallaghan@alterapraxis.com)]

Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8035

-gerrit

commit aa17dca7aa36da483cb2124d13d6110e813d8717
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Fri Jan 2 15:11:49 2015 +1100

    northbridge/amd/agesa/familyXY: Make NULL device op explicit
    
    Use 'DEVICE_NOOP' macro introduced in:
    
     commit 530355d include/device/device.h: Provide DEVICE_NOOP macro shim
    
    to provide formalism. Make the null device ops here explicit and
    in-line with formalism elsewhere.
    
    Change-Id: I2400b29a5108a6bae21959177e53321810ca1407
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/northbridge/amd/agesa/family10/northbridge.c   | 2 +-
 src/northbridge/amd/agesa/family12/northbridge.c   | 4 ++--
 src/northbridge/amd/agesa/family14/northbridge.c   | 4 ++--
 src/northbridge/amd/agesa/family15/northbridge.c   | 2 +-
 src/northbridge/amd/agesa/family15rl/northbridge.c | 2 +-
 src/northbridge/amd/agesa/family15tn/northbridge.c | 2 +-
 src/northbridge/amd/agesa/family16kb/northbridge.c | 2 +-
 7 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/northbridge/amd/agesa/family10/northbridge.c b/src/northbridge/amd/agesa/family10/northbridge.c
index 2b2dad5..3099585 100644
--- a/src/northbridge/amd/agesa/family10/northbridge.c
+++ b/src/northbridge/amd/agesa/family10/northbridge.c
@@ -945,7 +945,7 @@ static struct device_operations pci_domain_ops = {
 	.read_resources	  = amdfam10_domain_read_resources,
 	.set_resources	  = amdfam10_domain_set_resources,
 	.enable_resources = amdfam10_domain_enable_resources,
-	.init		  = NULL,
+	.init		  = DEVICE_NOOP,
 	.scan_bus	  = amdfam10_domain_scan_bus,
 	.ops_pci_bus	  = pci_bus_default_ops,
 };
diff --git a/src/northbridge/amd/agesa/family12/northbridge.c b/src/northbridge/amd/agesa/family12/northbridge.c
index a3b3493..9d078ed 100644
--- a/src/northbridge/amd/agesa/family12/northbridge.c
+++ b/src/northbridge/amd/agesa/family12/northbridge.c
@@ -932,7 +932,7 @@ static struct device_operations pci_domain_ops = {
 	.read_resources   = domain_read_resources,
 	.set_resources    = domain_set_resources,
 	.enable_resources = domain_enable_resources,
-	.init             = NULL,
+	.init             = DEVICE_NOOP,
 	.scan_bus         = pci_domain_scan_bus,
 };
 
@@ -940,7 +940,7 @@ static struct device_operations pci_domain_ops = {
 static struct device_operations cpu_bus_ops = {
 	.read_resources   = cpu_bus_read_resources,
 	.set_resources    = cpu_bus_set_resources,
-	.enable_resources = NULL,
+	.enable_resources = DEVICE_NOOP,
 	.init             = cpu_bus_init,
 	.scan_bus         = 0,
 };
diff --git a/src/northbridge/amd/agesa/family14/northbridge.c b/src/northbridge/amd/agesa/family14/northbridge.c
index ff669ef..4017944 100644
--- a/src/northbridge/amd/agesa/family14/northbridge.c
+++ b/src/northbridge/amd/agesa/family14/northbridge.c
@@ -947,14 +947,14 @@ static struct device_operations pci_domain_ops = {
 	.read_resources = domain_read_resources,
 	.set_resources = domain_set_resources,
 	.enable_resources = domain_enable_resources,
-	.init = NULL,
+	.init = DEVICE_NOOP,
 	.scan_bus = pci_domain_scan_bus,
 };
 
 static struct device_operations cpu_bus_ops = {
 	.read_resources = DEVICE_NOOP,
 	.set_resources = DEVICE_NOOP,
-	.enable_resources = NULL,
+	.enable_resources = DEVICE_NOOP,
 	.init = cpu_bus_init,
 	.scan_bus = cpu_bus_scan,
 };
diff --git a/src/northbridge/amd/agesa/family15/northbridge.c b/src/northbridge/amd/agesa/family15/northbridge.c
index c030d57..2a816ff 100644
--- a/src/northbridge/amd/agesa/family15/northbridge.c
+++ b/src/northbridge/amd/agesa/family15/northbridge.c
@@ -968,7 +968,7 @@ static struct device_operations pci_domain_ops = {
 	.read_resources	  = domain_read_resources,
 	.set_resources	  = domain_set_resources,
 	.enable_resources = domain_enable_resources,
-	.init		  = NULL,
+	.init		  = DEVICE_NOOP,
 	.scan_bus	  = f15_pci_domain_scan_bus,
 	.ops_pci_bus	  = pci_bus_default_ops,
 };
diff --git a/src/northbridge/amd/agesa/family15rl/northbridge.c b/src/northbridge/amd/agesa/family15rl/northbridge.c
index a27e902..867a9d9 100644
--- a/src/northbridge/amd/agesa/family15rl/northbridge.c
+++ b/src/northbridge/amd/agesa/family15rl/northbridge.c
@@ -957,7 +957,7 @@ static struct device_operations pci_domain_ops = {
 	.read_resources	  = domain_read_resources,
 	.set_resources	  = domain_set_resources,
 	.enable_resources = domain_enable_resources,
-	.init		  = NULL,
+	.init		  = DEVICE_NOOP,
 	.scan_bus	  = pci_domain_scan_bus,
 	.ops_pci_bus	  = pci_bus_default_ops,
 };
diff --git a/src/northbridge/amd/agesa/family15tn/northbridge.c b/src/northbridge/amd/agesa/family15tn/northbridge.c
index c7f7fef..8993923 100644
--- a/src/northbridge/amd/agesa/family15tn/northbridge.c
+++ b/src/northbridge/amd/agesa/family15tn/northbridge.c
@@ -955,7 +955,7 @@ static struct device_operations pci_domain_ops = {
 	.read_resources	  = domain_read_resources,
 	.set_resources	  = domain_set_resources,
 	.enable_resources = domain_enable_resources,
-	.init		  = NULL,
+	.init		  = DEVICE_NOOP,
 	.scan_bus	  = pci_domain_scan_bus,
 	.ops_pci_bus	  = pci_bus_default_ops,
 };
diff --git a/src/northbridge/amd/agesa/family16kb/northbridge.c b/src/northbridge/amd/agesa/family16kb/northbridge.c
index 86adfae..9c16dfb 100644
--- a/src/northbridge/amd/agesa/family16kb/northbridge.c
+++ b/src/northbridge/amd/agesa/family16kb/northbridge.c
@@ -999,7 +999,7 @@ static struct device_operations pci_domain_ops = {
 	.read_resources	  = domain_read_resources,
 	.set_resources	  = domain_set_resources,
 	.enable_resources = domain_enable_resources,
-	.init		  = NULL,
+	.init		  = DEVICE_NOOP,
 	.scan_bus	  = pci_domain_scan_bus,
 	.ops_pci_bus	  = pci_bus_default_ops,
 };