[coreboot-gerrit] Patch merged into coreboot/master: southbridge/amd/sb600: Update HPET base address with #define
gerrit at coreboot.org
gerrit at coreboot.org
Wed Dec 16 00:56:16 CET 2015
the following patch was just integrated into master:
commit 1e1c7ac3b4cb6d85eb602e04b0e4da8c042846c0
Author: Martin Roth <martinroth at google.com>
Date: Thu Dec 10 08:19:27 2015 -0700
southbridge/amd/sb600: Update HPET base address with #define
The SB600 code had the base address of the HPET hardcoded throughout.
It looks like the plan was to have it be updated in ACPI if needed,
but this wasn't ever implemented. The variable names being used to
do this update were the same, causing an IASL warning. Because of
this, the operation to update the HPET address actually did nothing.
This was fine, because it didn't actually need to be updated.
- Replace all that code with a #define.
- Add and update some comments in the same area.
Fixes IASL warning:
dsdt.aml 1505: Store(HPBA, HPBA)
Warning 3023 - ^ Duplicate value in list (Source is the
same as Target)
Change-Id: I9ba5fe226a4a464e0045ce7d3406898760df5e5a
Signed-off-by: Martin Roth <martinroth at google.com>
Reviewed-on: https://review.coreboot.org/12705
Tested-by: build bot (Jenkins)
Reviewed-by: Timothy Pearson <tpearson at raptorengineeringinc.com>
See https://review.coreboot.org/12705 for details.
-gerrit
More information about the coreboot-gerrit
mailing list