[coreboot-gerrit] Patch set updated for coreboot: Kconfig: Fix CONFIG_GDB_STUB dependencies
Denis Carikli (GNUtoo@no-log.org)
gerrit at coreboot.org
Fri Dec 11 00:26:25 CET 2015
Denis Carikli (GNUtoo at no-log.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12708
-gerrit
commit 027f6e7338f4d0977d849a0939566b40e90643fb
Author: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
Date: Thu Dec 10 22:04:56 2015 +0100
Kconfig: Fix CONFIG_GDB_STUB dependencies
If we select CONFIG_GDB_STUB without CONFIG_SERIAL:
build/console/console.romstage.o: In function `__gdb_hw_init':
[...]src/include/console/uart.h:74: undefined reference to `uart_init'
build/console/console.romstage.o: In function `__gdb_tx_byte':
[...]/src/include/console/uart.h:75: undefined reference to `uart_tx_byte'
build/console/console.romstage.o: In function `__gdb_tx_flush':
[...]/src/include/console/uart.h:76: undefined reference to `uart_tx_flush'
build/console/console.romstage.o: In function `__gdb_rx_byte':
[...]/src/include/console/uart.h:77: undefined reference to `uart_rx_byte'
Note that CONFIG_GDB_STUB should also work trough usbdebug,
But due to the lack of testing, it has been disabled when added.
This commit gives more information on the issue:
f2f7f03 console: Add console for GDB
Change-Id: I9accf8189dfd2c4ae379c03649d2e5863183457b
Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
---
src/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/Kconfig b/src/Kconfig
index 8439a00..293673d 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -716,6 +716,7 @@ menu "Debugging"
config GDB_STUB
bool "GDB debugging support"
default n
+ depends on CONSOLE_SERIAL
help
If enabled, you will be able to set breakpoints for gdb debugging.
See src/arch/x86/lib/c_start.S for details.
More information about the coreboot-gerrit
mailing list