[coreboot-gerrit] Patch set updated for coreboot: ACPI: Fix IASL Warning about unused method for _TZ checks
Martin Roth (martinroth@google.com)
gerrit at coreboot.org
Wed Dec 9 16:45:50 CET 2015
Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12695
-gerrit
commit 9e6401737bd7f362d320dc6fdc4490f80ca082d1
Author: Martin Roth <martinroth at google.com>
Date: Tue Dec 8 15:26:46 2015 -0700
ACPI: Fix IASL Warning about unused method for _TZ checks
According to the ACPI Spec for CondRefOf, the result argument is
optional. In all of these locations, it was getting set but not
used, creating a warning in new versions of IASL. Since it's
an optional argument, just remove it.
dsdt.aml 640: If (CondRefOf (^GBUF, Local0)) {
Warning 3144 - Method Local is set but never used ^ (Local0)
Change-Id: Iddf46a4faab19019882847917397eee0614302b9
Signed-off-by: Martin Roth <martinroth at google.com>
---
src/southbridge/intel/bd82x6x/acpi/globalnvs.asl | 4 ++--
src/southbridge/intel/fsp_bd82x6x/acpi/globalnvs.asl | 4 ++--
src/southbridge/intel/fsp_i89xx/acpi/globalnvs.asl | 4 ++--
src/southbridge/intel/lynxpoint/acpi/globalnvs.asl | 4 ++--
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/southbridge/intel/bd82x6x/acpi/globalnvs.asl b/src/southbridge/intel/bd82x6x/acpi/globalnvs.asl
index 68b4190..ad02716 100644
--- a/src/southbridge/intel/bd82x6x/acpi/globalnvs.asl
+++ b/src/southbridge/intel/bd82x6x/acpi/globalnvs.asl
@@ -238,12 +238,12 @@ External (\_TZ.SKIN)
Method (TZUP)
{
/* Update Primary Thermal Zone */
- If (CondRefOf (\_TZ.THRM, Local0)) {
+ If (CondRefOf (\_TZ.THRM)) {
Notify (\_TZ.THRM, 0x81)
}
/* Update Secondary Thermal Zone */
- If (CondRefOf (\_TZ.SKIN, Local0)) {
+ If (CondRefOf (\_TZ.SKIN)) {
Notify (\_TZ.SKIN, 0x81)
}
}
diff --git a/src/southbridge/intel/fsp_bd82x6x/acpi/globalnvs.asl b/src/southbridge/intel/fsp_bd82x6x/acpi/globalnvs.asl
index 0fb943c..3adf3ca 100644
--- a/src/southbridge/intel/fsp_bd82x6x/acpi/globalnvs.asl
+++ b/src/southbridge/intel/fsp_bd82x6x/acpi/globalnvs.asl
@@ -224,12 +224,12 @@ External (\_TZ.SKIN)
Method (TZUP)
{
/* Update Primary Thermal Zone */
- If (CondRefOf (\_TZ.THRM, Local0)) {
+ If (CondRefOf (\_TZ.THRM)) {
Notify (\_TZ.THRM, 0x81)
}
/* Update Secondary Thermal Zone */
- If (CondRefOf (\_TZ.SKIN, Local0)) {
+ If (CondRefOf (\_TZ.SKIN)) {
Notify (\_TZ.SKIN, 0x81)
}
}
diff --git a/src/southbridge/intel/fsp_i89xx/acpi/globalnvs.asl b/src/southbridge/intel/fsp_i89xx/acpi/globalnvs.asl
index f124eb0..e1e0e66 100644
--- a/src/southbridge/intel/fsp_i89xx/acpi/globalnvs.asl
+++ b/src/southbridge/intel/fsp_i89xx/acpi/globalnvs.asl
@@ -228,12 +228,12 @@ External (\_TZ.SKIN)
Method (TZUP)
{
/* Update Primary Thermal Zone */
- If (CondRefOf (\_TZ.THRM, Local0)) {
+ If (CondRefOf (\_TZ.THRM)) {
Notify (\_TZ.THRM, 0x81)
}
/* Update Secondary Thermal Zone */
- If (CondRefOf (\_TZ.SKIN, Local0)) {
+ If (CondRefOf (\_TZ.SKIN)) {
Notify (\_TZ.SKIN, 0x81)
}
}
diff --git a/src/southbridge/intel/lynxpoint/acpi/globalnvs.asl b/src/southbridge/intel/lynxpoint/acpi/globalnvs.asl
index cbc3bd7..468c755 100644
--- a/src/southbridge/intel/lynxpoint/acpi/globalnvs.asl
+++ b/src/southbridge/intel/lynxpoint/acpi/globalnvs.asl
@@ -222,12 +222,12 @@ External (\_TZ.SKIN)
Method (TZUP)
{
/* Update Primary Thermal Zone */
- If (CondRefOf (\_TZ.THRM, Local0)) {
+ If (CondRefOf (\_TZ.THRM)) {
Notify (\_TZ.THRM, 0x81)
}
/* Update Secondary Thermal Zone */
- If (CondRefOf (\_TZ.SKIN, Local0)) {
+ If (CondRefOf (\_TZ.SKIN)) {
Notify (\_TZ.SKIN, 0x81)
}
}
More information about the coreboot-gerrit
mailing list