[coreboot-gerrit] New patch to review for coreboot: cbfs: Fix typo in cbfs_prog_stage_load()
Julius Werner (jwerner@chromium.org)
gerrit at coreboot.org
Thu Dec 3 20:31:50 CET 2015
Julius Werner (jwerner at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12633
-gerrit
commit ba72a9406cacacce1c4296cf0b75e343464e84c7
Author: Julius Werner <jwerner at chromium.org>
Date: Thu Dec 3 11:29:12 2015 -0800
cbfs: Fix typo in cbfs_prog_stage_load()
The proper return value to signal an error from cbfs_prog_stage_load()
is -1, not 0.
Change-Id: Ie53b0359c7c036e3f809d1f941dab53f090b84ab
Signed-off-by: Julius Werner <jwerner at chromium.org>
---
src/lib/cbfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/cbfs.c b/src/lib/cbfs.c
index 57b64dd..c782818 100644
--- a/src/lib/cbfs.c
+++ b/src/lib/cbfs.c
@@ -202,7 +202,7 @@ int cbfs_prog_stage_load(struct prog *pstage)
const struct region_device *fh = prog_rdev(pstage);
if (rdev_readat(fh, &stage, 0, sizeof(stage)) != sizeof(stage))
- return 0;
+ return -1;
fsize = region_device_sz(fh);
fsize -= sizeof(stage);
More information about the coreboot-gerrit
mailing list