[coreboot-gerrit] New patch to review for coreboot: rk3288: Set HDMI display mode to 480p

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Thu Aug 27 15:39:16 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11392

-gerrit

commit 7de41aaac35b625a97db8b0dc2d67442acfa6eb1
Author: Yakir Yang <ykk at rock-chips.com>
Date:   Wed Jul 29 08:54:14 2015 -0500

    rk3288: Set HDMI display mode to 480p
    
    If an HDMI display is detected (EDID can be read), set the
    display mode to 480p. If for some reason 480p is not supported
    then we'll fall back to the automatically detected display mode.
    
    BUG=chrome-os-partner:42946
    BRANCH=firmware-veyron
    TEST=dev mode screen shows up on Mickey at 480p resolution
    
    Change-Id: I2c431eff6673392d3c09e1b66c66ba12ecc6eeb0
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
    Original-Commit-Id: 76203a683c4501f368c50fe24101f68746ddb7f0
    Original-Change-Id: I90dea37daa2d78628230d7d47f7ef0e917cbd7bb
    Original-Signed-off-by: David Hendricks <dhendrix at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/290554
    Original-Reviewed-by: Julius Werner <jwerner at chromium.org>
---
 src/soc/rockchip/rk3288/hdmi.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/soc/rockchip/rk3288/hdmi.c b/src/soc/rockchip/rk3288/hdmi.c
index e5bebe3..a520399 100644
--- a/src/soc/rockchip/rk3288/hdmi.c
+++ b/src/soc/rockchip/rk3288/hdmi.c
@@ -793,6 +793,10 @@ int rk_hdmi_get_edid(struct edid *edid)
 	if (decode_edid(edid_buf, edid_size, edid))
 		hdmi_debug("failed to decode edid.\n");
 
+	/* Try 480p for best compatibility. */
+	if (set_display_mode(edid, EDID_MODE_640x480_60Hz))
+		hdmi_debug("failed to set mode to 640x480 at 60Hz\n");
+
 	return 0;
 }
 



More information about the coreboot-gerrit mailing list