[coreboot-gerrit] Patch set updated for coreboot: libpayload: Fix default_memmove() implementation
Nico Huber (nico.h@gmx.de)
gerrit at coreboot.org
Wed Aug 19 18:03:04 CEST 2015
Nico Huber (nico.h at gmx.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11286
-gerrit
commit 5a44df4f17009eb50cd842840d36faadca3b5da6
Author: Nico Huber <nico.huber at secunet.com>
Date: Wed Aug 19 17:22:26 2015 +0200
libpayload: Fix default_memmove() implementation
If I wanted to fill the whole memory address space with one byte, I
wouldn't try it that subtle.
With size_t beeing unsigned the loop condition >= 0 was always true.
Change-Id: Idee6a4901f6697093c88bda354b5e43066c0d948
Signed-off-by: Nico Huber <nico.huber at secunet.com>
---
payloads/libpayload/libc/memory.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/payloads/libpayload/libc/memory.c b/payloads/libpayload/libc/memory.c
index 07a4d08..ae476cf 100644
--- a/payloads/libpayload/libc/memory.c
+++ b/payloads/libpayload/libc/memory.c
@@ -78,7 +78,8 @@ void *memcpy(void *dst, const void *src, size_t n)
static void *default_memmove(void *dst, const void *src, size_t n)
{
- size_t i, offs;
+ size_t offs;
+ ssize_t i;
if (src > dst)
return memcpy(dst, src, n);
More information about the coreboot-gerrit
mailing list