[coreboot-gerrit] Patch set updated for coreboot: soc/intel/skylake/Kconfig: Fix recursive Kconfig dependency

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Mon Aug 17 17:34:58 CEST 2015


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11243

-gerrit

commit f473e6f39bb5ea6497fbbe05960d5907eeeb72b8
Author: Martin Roth <martinroth at google.com>
Date:   Sat Aug 15 17:36:15 2015 -0600

    soc/intel/skylake/Kconfig: Fix recursive Kconfig dependency
    
    Change the dependency on CONSOLE_SERIAL to select CONSOLE_SERIAL based
    on this question.
    The dependency was causing multiple warnings on every platform tested.
    
    src/console/Kconfig:21:error: recursive dependency detected!
    src/console/Kconfig:21:	symbol CONSOLE_SERIAL depends on
    DRIVERS_UART_8250MEM
    src/drivers/uart/Kconfig:16:	symbol DRIVERS_UART_8250MEM is selected by
    UART_DEBUG
    src/soc/intel/skylake/Kconfig:198:	symbol UART_DEBUG depends on
    CONSOLE_SERIAL
    
    Change-Id: Ia0426cd150561694081b5ea7c6797d36022c1f57
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 src/soc/intel/skylake/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/soc/intel/skylake/Kconfig b/src/soc/intel/skylake/Kconfig
index 6c64cd9..9d920d8 100644
--- a/src/soc/intel/skylake/Kconfig
+++ b/src/soc/intel/skylake/Kconfig
@@ -195,8 +195,8 @@ config VGA_BIOS_ID
 
 config UART_DEBUG
 	bool "Enable UART debug port."
-	default y if CONSOLE_SERIAL
 	default n
+	select CONSOLE_SERIAL
 	select DRIVERS_UART
 	select DRIVERS_UART_8250MEM
 	select DRIVERS_UART_8250MEM_32



More information about the coreboot-gerrit mailing list