[coreboot-gerrit] New patch to review for coreboot: AMD Binary PI: Fix the build when the user's group has a space

Dan Christensen (opello@opello.org) gerrit at coreboot.org
Sat Aug 15 20:10:30 CEST 2015


Dan Christensen (opello at opello.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11242

-gerrit

commit 4eb75bea30dd9301f9f1f5b88fe8b1200c442f8c
Author: Dan Christensen <opello at opello.org>
Date:   Sat Aug 15 11:05:04 2015 -0500

    AMD Binary PI: Fix the build when the user's group has a space
    
    When the user's primary group contains a space ls -l and awk get the
    wrong value for the file size.  This results in padding the
    coreboot_psp_directory_combine_pubkey.bin file too much which ultimately
    means RtmPubSigned.key can not be placed at the necessary offset.
    
    Changing from ls -l to ls -ln seemed like the most minimal,
    POSIX-friendly way to effect this change.
    
    Change-Id: Icbeaad476753924626adb6de53dc9a30052d91a6
    Signed-off-by: Dan Christensen <opello at opello.org>
---
 src/southbridge/amd/pi/hudson/Makefile.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/southbridge/amd/pi/hudson/Makefile.inc b/src/southbridge/amd/pi/hudson/Makefile.inc
index 73b15f9..99d966f 100644
--- a/src/southbridge/amd/pi/hudson/Makefile.inc
+++ b/src/southbridge/amd/pi/hudson/Makefile.inc
@@ -348,7 +348,7 @@ endif
 	for fwm in 11 4294967295 1 0; do \
 	echo  $$fwm | LC_ALL=C awk '{printf ("%c%c%c%c", $$1 % 256, int($$1/256) % 256, int($$1/65536) % 256, int($$1/16777216));}'; \
 	done >> $@_tail.tmp
-	for fwm in  1347637284 0 `ls -l $@_tail.tmp | awk '{printf("%d", $$5/16);}'` 0; do \
+	for fwm in  1347637284 0 `ls -ln $@_tail.tmp | awk '{printf("%d", $$5/16);}'` 0; do \
 		echo  $$fwm | LC_ALL=C awk '{printf ("%c%c%c%c", $$1 % 256, int($$1/256) % 256, int($$1/65536) % 256, int($$1/16777216));}'; \
 	done > $@_head.tmp
 	cat $@_head.tmp $@_tail.tmp > $@.tmp
@@ -357,7 +357,7 @@ endif
 
 $(obj)/coreboot_psp_directory_combine_pubkey.bin: $(obj)/coreboot_psp_directory.bin
 	cat  $(obj)/coreboot_psp_directory.bin > $@
-	ls -l $(obj)/coreboot_psp_directory.bin | LC_ALL=C awk '{for (i=0; i<256-$$5; i++) {printf "%c", 255}}' >> $@
+	ls -ln $(obj)/coreboot_psp_directory.bin | LC_ALL=C awk '{for (i=0; i<256-$$5; i++) {printf "%c", 255}}' >> $@
 	cat  $(top)/$(FIRMWARE_LOCATE)/AmdPubKey$(FIRMWARE_TYPE).bin >> $@
 
 cbfs-files-y += apu/pspdir



More information about the coreboot-gerrit mailing list