[coreboot-gerrit] Patch merged into coreboot/master: intel/common: fix stage_cache_external_region()

gerrit at coreboot.org gerrit at coreboot.org
Fri Aug 14 15:19:45 CEST 2015


the following patch was just integrated into master:
commit c43d417039ad8f1d207c15ba0e9fb407d2091c94
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Wed Aug 5 14:51:48 2015 -0500

    intel/common: fix stage_cache_external_region()
    
    The stage_cache_external_region() calculation is actually
    dependennt on the properties of the chipset. The reason
    is that certain regions within the SMRAM are used for
    chipset-specific features. Therefore, provide an API
    for abstracting the querying of subregions within
    the SMRAM.
    
    The 3 subregions introduced are:
    
    SMM_SUBREGION_HANDLER - SMM handler area
    SMM_SUBREGION_CACHE - SMM cache region
    SMM_SUBREGION_CHIPSET - Chipset specific area.
    
    The subregions can be queried using the newly
    added smm_subregion() function.
    
    Now stage_cache_external_region() uses smm_subregion()
    to query the external stage cache in SMRAM, and this
    patch also eliminates 2 separate implementations of
    stage_cache_external_region() between romstage and
    ramstage.
    
    BUG=chrome-os-partner:43636
    BRANCH=None
    TEST=Built, booted, suspended, resumed on glados.
    
    Original-Change-Id: Id669326ba9647117193aa604038b38b364ff0f82
    Original-Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/290833
    Original-Reviewed-by: Leroy P Leahy <leroy.p.leahy at intel.com>
    Original-Reviewed-by: Duncan Laurie <dlaurie at chromium.org>
    
    Change-Id: Idb1a75d93c9b87053a7dedb82e85afc7df6334e0
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: http://review.coreboot.org/11197
    Tested-by: build bot (Jenkins)
    Reviewed-by: Patrick Georgi <pgeorgi at google.com>


See http://review.coreboot.org/11197 for details.

-gerrit



More information about the coreboot-gerrit mailing list